Attention is currently required from: Martin L Roth, ritul guru, Zheng Bao.
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69856 )
Change subject: amdfwtool: Allow the location to be a relative address ......................................................................
Patch Set 17:
(2 comments)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/69856/comment/e3c15c90_dcfdd0da PS17, Line 2499: /* Relative address. */
What does this comment mean? Is it for the things above the comment? If it's for things below the c […]
Done. It used to be abs addresses in the switch/case. Now only relative addresses. Move it to above.
https://review.coreboot.org/c/coreboot/+/69856/comment/da64520b_2f03c953 PS17, Line 2505: /* Special cases for 8M */
What if a ROM smaller than 8MiB is used on an older platform? Would we need more special cases?
Done
-
Bao Zheng (Code Review)