Hannah Williams has posted comments on this change. ( https://review.coreboot.org/19759 )
Change subject: soc/intel/common/block/gpio: Port gpio code from Apollolake into common gpio
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/19759/5/src/soc/intel/common/block/include/i...
File src/soc/intel/common/block/include/intelblocks/gpio_defs.h:
PS5, Line 61: #define PAD_CFG0_RESET_MASK (3 << 30)
: #define PAD_CFG0_RESET_PWROK (0 << 30)
: #define PAD_CFG0_RESET_DEEP (1 << 30)
: #define PAD_CFG0_RESET_PLTRST (2 << 30)
: #define PAD_CFG0_RESET_RSMRST (3 << 30)
Please note: https://mail.coreboot.org/pipermail/coreboot/2017-May/084296.h
I will follow up on this
--
To view, visit
https://review.coreboot.org/19759
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic48401e92103ff0ec278fb69a3d304148a2d79aa
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Barnali Sarkar
barnali.sarkar@intel.com
Gerrit-Reviewer: Divya Chellappa
divya.chella@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-HasComments: Yes