Attention is currently required from: Daniel Peng, Kapil Porwal, Nick Vaccaro, Paul Menzel, Shawn Ku, Subrata Banik.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80764?usp=email )
Change subject: mb/google/nissa/var/glassway: Add GPIO table
......................................................................
Patch Set 3:
(4 comments)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/80764/comment/ef6b9b5a_de70460b :
PS3, Line 239: select DRIVERS_GENERIC_GPIO_KEYS
this is not related to gpio, please move to device tree CL.
https://review.coreboot.org/c/coreboot/+/80764/comment/ed4cac2d_9d954e2c :
PS3, Line 240: select DRIVERS_GENESYSLOGIC_GL9750
same.
File src/mainboard/google/brya/variants/glassway/gpio.c:
https://review.coreboot.org/c/coreboot/+/80764/comment/61817926_4beedd91 :
PS3, Line 5: #include <boardid.h>
remove.
https://review.coreboot.org/c/coreboot/+/80764/comment/058cc70e_32655c05 :
PS3, Line 6: #include <commonlib/helpers.h>
same.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80764?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0de743746160c6eb081cb9a061ac1703b01ba5b4
Gerrit-Change-Number: 80764
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Shawn Ku
shawnku@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Shawn Ku
shawnku@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-Comment-Date: Tue, 27 Feb 2024 04:14:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment