Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37740 )
Change subject: device/pnp: use correct width type for pnp_info.function ......................................................................
device/pnp: use correct width type for pnp_info.function
Change-Id: Idbc1b37a8c98fe7fa24d8632e6a55c046e2d2869 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/include/device/pnp.h 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/37740/1
diff --git a/src/include/device/pnp.h b/src/include/device/pnp.h index 69a06674..a3222d2 100644 --- a/src/include/device/pnp.h +++ b/src/include/device/pnp.h @@ -34,7 +34,7 @@
struct pnp_info { struct device_operations *ops; /* LDN-specific ops override */ - unsigned int function; /* Must be at least 16 bits (virtual LDNs)! */ + u16 function; /* Must be at least 16 bits (virtual LDNs)! */ unsigned int flags; #define PNP_IO0 0x000001 #define PNP_IO1 0x000002
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37740
to look at the new patch set (#2).
Change subject: device/pnp: use correct width type for pnp_info.function ......................................................................
device/pnp: use correct width type for pnp_info.function
Change-Id: Idbc1b37a8c98fe7fa24d8632e6a55c046e2d2869 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/include/device/pnp.h 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/37740/2
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37740 )
Change subject: device/pnp: use correct width type for pnp_info.function ......................................................................
Patch Set 2: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37740 )
Change subject: device/pnp: use correct width type for pnp_info.function ......................................................................
device/pnp: use correct width type for pnp_info.function
Change-Id: Idbc1b37a8c98fe7fa24d8632e6a55c046e2d2869 Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/37740 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org --- M src/include/device/pnp.h 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved
diff --git a/src/include/device/pnp.h b/src/include/device/pnp.h index fde4c9d..d459fd2 100644 --- a/src/include/device/pnp.h +++ b/src/include/device/pnp.h @@ -35,7 +35,7 @@ struct pnp_info { struct device_operations *ops; /* LDN-specific ops override */ #define PNP_SKIP_FUNCTION 0xffff - unsigned int function; /* Must be at least 16 bits (virtual LDNs)! */ + u16 function; /* Must be at least 16 bits (virtual LDNs)! */ unsigned int flags; #define PNP_IO0 0x000001 #define PNP_IO1 0x000002
-
Felix Held (Code Review) -
Patrick Rudolph (Code Review)