Attention is currently required from: Furquan Shaikh, Angel Pons, Subrata Banik, Aaron Durbin. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51445 )
Change subject: timestamp: Add helper fucntions ......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51445/comment/5feb4718_d84d75d9 PS3, Line 7: Add helper fucntions
I think the time_from_base in your naming is confusing, because all timestamp_add()s are relative […]
Sorry, yeah, I confused myself somehow there. You're right that we currently add absolute timestamps and for this you need some way to add relative ones. Switching to microseconds won't change that (although it would remove the need for extra frequency arguments everywhere).
(BTW, am I seeing this right that in this particular case, your rewind_base() would cause ts->base_time to underflow and become a large positive uint64_t? I guess fundamentally that should still work out right in the end, but it looks a bit weird. Maybe we should consider changing it to int64_t if we do that?)
-
Julius Werner (Code Review)