HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41672 )
Change subject: soc/amd/picasso: Remove unused 'include <romstage_handoff.h>' ......................................................................
soc/amd/picasso: Remove unused 'include <romstage_handoff.h>'
Change-Id: I07100361705ce421131b8a5d772cb5ba2d8722ff Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/amd/picasso/chip.c M src/soc/amd/picasso/romstage.c 2 files changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/41672/1
diff --git a/src/soc/amd/picasso/chip.c b/src/soc/amd/picasso/chip.c index 9c26f35..4ea962f 100644 --- a/src/soc/amd/picasso/chip.c +++ b/src/soc/amd/picasso/chip.c @@ -5,7 +5,6 @@ #include <device/device.h> #include <device/pci.h> #include <drivers/i2c/designware/dw_i2c.h> -#include <romstage_handoff.h> #include <soc/acpi.h> #include <soc/cpu.h> #include <soc/data_fabric.h> diff --git a/src/soc/amd/picasso/romstage.c b/src/soc/amd/picasso/romstage.c index a2ca055..0bbceec 100644 --- a/src/soc/amd/picasso/romstage.c +++ b/src/soc/amd/picasso/romstage.c @@ -10,7 +10,6 @@ #include <commonlib/helpers.h> #include <console/console.h> #include <program_loading.h> -#include <romstage_handoff.h> #include <elog.h> #include <soc/romstage.h> #include <soc/mtrr.h>
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41672 )
Change subject: soc/amd/picasso: Remove unused 'include <romstage_handoff.h>' ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41672 )
Change subject: soc/amd/picasso: Remove unused 'include <romstage_handoff.h>' ......................................................................
soc/amd/picasso: Remove unused 'include <romstage_handoff.h>'
Change-Id: I07100361705ce421131b8a5d772cb5ba2d8722ff Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/41672 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/picasso/chip.c M src/soc/amd/picasso/romstage.c 2 files changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/soc/amd/picasso/chip.c b/src/soc/amd/picasso/chip.c index 9c26f35..4ea962f 100644 --- a/src/soc/amd/picasso/chip.c +++ b/src/soc/amd/picasso/chip.c @@ -5,7 +5,6 @@ #include <device/device.h> #include <device/pci.h> #include <drivers/i2c/designware/dw_i2c.h> -#include <romstage_handoff.h> #include <soc/acpi.h> #include <soc/cpu.h> #include <soc/data_fabric.h> diff --git a/src/soc/amd/picasso/romstage.c b/src/soc/amd/picasso/romstage.c index a2ca055..0bbceec 100644 --- a/src/soc/amd/picasso/romstage.c +++ b/src/soc/amd/picasso/romstage.c @@ -10,7 +10,6 @@ #include <commonlib/helpers.h> #include <console/console.h> #include <program_loading.h> -#include <romstage_handoff.h> #include <elog.h> #include <soc/romstage.h> #include <soc/mtrr.h>
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41672 )
Change subject: soc/amd/picasso: Remove unused 'include <romstage_handoff.h>' ......................................................................
Patch Set 4:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4596 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4595 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4594 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4593
Please note: This test is under development and might not be accurate at all!