Attention is currently required from: Arthur Heymans, Chen, Gang C, Fred Reitberger, Jason Glenesk, Jincheng Li, Jérémy Compostella, Martin L Roth, Matt DeVillier.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78328?usp=email )
Change subject: device/device.h: Drop multiple links ......................................................................
Patch Set 8:
(6 comments)
Patchset:
PS8: i like what this patch is doing. it however needs a probably rather manual rebase after the pci segment group support landed
File src/device/device.c:
https://review.coreboot.org/c/coreboot/+/78328/comment/abc70cff_60652f35 : PS8, Line 607: final_link(dev_root.link_list); don't know sconfig too well, so i wonder if we can safely assume that dev_root is always present and non-null?
File src/device/device_util.c:
https://review.coreboot.org/c/coreboot/+/78328/comment/07fe411e_5109f584 : PS8, Line 250: : const char *bus_path(struct bus *bus) : { : static char buffer[BUS_PATH_MAX]; : snprintf(buffer, sizeof(buffer), : "%s,%d", dev_path(bus->dev), bus->link_num); : return buffer; : } this function is unused, right? if so, i'd prefer if you drop this function and the corresponding prototype in the header file in a separate patch before this one
File src/southbridge/amd/pi/hudson/lpc.c:
https://review.coreboot.org/c/coreboot/+/78328/comment/0a2c7e61_0f2aae79 : PS8, Line 173: struct device *child; this could be kept inside the if block that starts on the line below, since it's never used outside of that block, but i don't have a strong opinion on this one
https://review.coreboot.org/c/coreboot/+/78328/comment/dde059b1_dacf276a : PS8, Line 187: dev_path(child), base, end); i'd strongly prefer to not also have some unrelated whitespace changes in this patch. same on all lines below
File util/sconfig/main.c:
PS8: i'm not 100% sure about the details of sconfig, so it would be good if someone else can have a look at this. didn't spot anything that looked off, but can't say that i have fully understood all details here