Attention is currently required from: Hung-Te Lin, Yidi Lin.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76919?usp=email )
Change subject: soc/mediatek/mt8188: Support ARM arch timer ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
File src/soc/mediatek/mt8188/Kconfig:
https://review.coreboot.org/c/coreboot/+/76919/comment/1b0bfda2_a3a243e4 : PS1, Line 16: select ARM64_USE_ARCH_TIMER
Shouldn't we select this from chromium overlay?
We can't because ARM64_USE_ARCH_TIMER has no prompt string.
File src/soc/mediatek/mt8188/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/76919/comment/77318f4f_ac486001 : PS1, Line 9: all-y += timer.c ../common/timer_prepare.c
Add timer.c if ARM64_USE_ARCH_TIMER. Otherwise common/timer.c.
Acknowledged