Change in ...coreboot[master]: util/bincfg: Fix building

[Arthur Heymans (Code Review)]

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31106

Change subject: util/bincfg: Fix building
......................................................................

util/bincfg: Fix building

48c24ce  "util/bincfg: code cleanup: convert sym_table to a local
variable" used non existing types in function declarations.

Change-Id: I862659c008488f609be14486722dc008919285e5
Signed-off-by: Arthur Heymans 
---
M util/bincfg/bincfg.h
M util/bincfg/bincfg.l
M util/bincfg/bincfg.y
3 files changed, 6 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/31106/1

diff --git a/util/bincfg/bincfg.h b/util/bincfg/bincfg.h
index c0e1242..25476ec 100644
--- a/util/bincfg/bincfg.h
+++ b/util/bincfg/bincfg.h
@@ -37,9 +37,9 @@
    unsigned int lenactualblob;
 };

-static struct field *putsym(field_ptr_t, char const *, unsigned int);
-static struct field *getsym(field_ptr_t, char const *);
-static void yyerror(FILE *, field_ptr_t, char const *);
+static struct field *putsym(struct field **, char const *, unsigned int);
+static struct field *getsym(struct field **, char const *);
+static void yyerror(FILE *, struct field **, char const *);
 int yylex(void);

static struct blob *binary;
diff --git a/util/bincfg/bincfg.l b/util/bincfg/bincfg.l
index f9e880f..c6f7171 100644
--- a/util/bincfg/bincfg.l
+++ b/util/bincfg/bincfg.l
@@ -17,10 +17,9 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
+#include "bincfg.h"
 #include "bincfg.tab.h"

-extern struct blob binary;
-
 unsigned int parsehex (char *s)
 {
    unsigned int i, nib, val = 0;
diff --git a/util/bincfg/bincfg.y b/util/bincfg/bincfg.y
index ac65d0f..854c539 100644
--- a/util/bincfg/bincfg.y
+++ b/util/bincfg/bincfg.y
@@ -124,14 +124,14 @@
    		sym_name);
    	return 0;
    }
-	struct field *ptr = (field_t ) malloc (sizeof (struct field));
+	struct field *ptr = (struct field *) malloc (sizeof (struct field));
    check_pointer(ptr);
    ptr->name = (char *) malloc (strlen (sym_name) + 1);
    check_pointer(ptr->name);
    strcpy (ptr->name, sym_name);
    ptr->width = w;
    ptr->value = 0;
-	ptr->next = (field_t)0;
+	ptr->next = (struct field *)NULL;
    if (sym_table_tail) {
    	sym_table_tail->next = ptr;
    } else {

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31106 )

Change subject: util/bincfg: Fix building
......................................................................

Patch Set 1:

Considering CB:31105 was submitted, is this needed anymore?

[Arthur Heymans (Code Review)]

Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/31106 )

Change subject: util/bincfg: Fix building
......................................................................

Abandoned

not needed anymore