Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/52602 )
Change subject: mb/google/mancomb: Remove lid swtich ......................................................................
mb/google/mancomb: Remove lid swtich
There is no lid switch in mancomb so remove it. Will replace the lid switch with a fake gpio in depthcharge.
BUG=b:182211161 TEST=Depthcharge no longer halts complaining that coreboot didn't sample the pin
Signed-off-by: Ivy Jian ivy_jian@compal.corp-partner.google.com Change-Id: Ifd0fcec9557bf7ebad64ce9342d3b50eb511522b Reviewed-on: https://review.coreboot.org/c/coreboot/+/52602 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Raul Rangel rrangel@chromium.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/mainboard/google/mancomb/chromeos.c 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Raul Rangel: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/mainboard/google/mancomb/chromeos.c b/src/mainboard/google/mancomb/chromeos.c index d2ef97e..4140a0a 100644 --- a/src/mainboard/google/mancomb/chromeos.c +++ b/src/mainboard/google/mancomb/chromeos.c @@ -8,7 +8,6 @@ void fill_lb_gpios(struct lb_gpios *gpios) { struct lb_gpio chromeos_gpios[] = { - {-1, ACTIVE_HIGH, get_lid_switch(), "lid"}, {-1, ACTIVE_HIGH, 0, "power"}, }; lb_add_gpios(gpios, chromeos_gpios, ARRAY_SIZE(chromeos_gpios));