[L] Change in coreboot[master]: [WIP] mb/prodrive/atlas: Put options in CFR cbtable - coreboot-gerrit

3 May 2023


      Attention is currently required from: Sean Rhodes, Benjamin Doron, Christian Walter, Maximilian Brune, Lean Sheng Tan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74122 )
Change subject: [WIP] mb/prodrive/atlas: Put options in CFR cbtable
......................................................................
Patch Set 4:
(2 comments)
File src/mainboard/prodrive/atlas/cfr.c:
https://review.coreboot.org/c/coreboot/+/74122/comment/3c917f37_6480493e 
PS4, Line 247: 		SM_DECLARE_BOOL(pcie_sris),
missing terminator. let's be explicit about array lengths instead...
https://review.coreboot.org/c/coreboot/+/74122/comment/0bcd4eb0_ab1a3966 
PS4, Line 257: 		SM_DECLARE_FORM(main_form),
missing terminator
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/74122
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47585a9a6f94ab5005f2ab63a0df267c0caef231
Gerrit-Change-Number: 74122
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Benjamin Doron benjamin.doron00@gmail.com
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Lean Sheng Tan sheng.tan@9elements.com
Gerrit-Reviewer: Maximilian Brune maximilian.brune@9elements.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Sean Rhodes sean@starlabs.systems
Gerrit-Attention: Sean Rhodes sean@starlabs.systems
Gerrit-Attention: Benjamin Doron benjamin.doron00@gmail.com
Gerrit-Attention: Christian Walter christian.walter@9elements.com
Gerrit-Attention: Maximilian Brune maximilian.brune@9elements.com
Gerrit-Attention: Lean Sheng Tan sheng.tan@9elements.com
Gerrit-Comment-Date: Wed, 03 May 2023 17:27:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment