HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44201 )
Change subject: src/arch: Include <stdint.h> ......................................................................
src/arch: Include <stdint.h>
Those file only needs <stdint.h>.
Change-Id: I8a4d1801125dcf271a4580b5ff50107745d2892e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/arch/arm/include/arch/clock.h M src/arch/arm64/include/bl31.h M src/arch/arm64/ramdetect.c 3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/44201/1
diff --git a/src/arch/arm/include/arch/clock.h b/src/arch/arm/include/arch/clock.h index 9387757..22e5287 100644 --- a/src/arch/arm/include/arch/clock.h +++ b/src/arch/arm/include/arch/clock.h @@ -3,7 +3,7 @@ #ifndef __ARM_CLOCK_H_ #define __ARM_CLOCK_H_
-#include <types.h> +#include <stdint.h>
void set_cntfrq(uint32_t);
diff --git a/src/arch/arm64/include/bl31.h b/src/arch/arm64/include/bl31.h index bb99fcd..1f946e9 100644 --- a/src/arch/arm64/include/bl31.h +++ b/src/arch/arm64/include/bl31.h @@ -3,7 +3,7 @@ #ifndef __BL31_H__ #define __BL31_H__
-#include <types.h> +#include <stdint.h>
#include <arm-trusted-firmware/include/export/lib/bl_aux_params/bl_aux_params_exp.h>
diff --git a/src/arch/arm64/ramdetect.c b/src/arch/arm64/ramdetect.c index 2f6a1cd..deaf390 100644 --- a/src/arch/arm64/ramdetect.c +++ b/src/arch/arm64/ramdetect.c @@ -1,8 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */
-#include <types.h> #include <device/mmio.h> #include <ramdetect.h> +#include <stdint.h> #include <arch/exception.h> #include <arch/transition.h>
Hello Julius Werner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44201
to look at the new patch set (#2).
Change subject: src/arch: Include <stdint.h> ......................................................................
src/arch: Include <stdint.h>
Those files only needs <stdint.h>.
Change-Id: I8a4d1801125dcf271a4580b5ff50107745d2892e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/arch/arm/include/arch/clock.h M src/arch/arm64/include/bl31.h M src/arch/arm64/ramdetect.c 3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/44201/2
Hello build bot (Jenkins), Julius Werner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44201
to look at the new patch set (#4).
Change subject: src/arch: Replace <types.h> with <stdint.h> ......................................................................
src/arch: Replace <types.h> with <stdint.h>
Those files only needs <stdint.h>.
Change-Id: I8a4d1801125dcf271a4580b5ff50107745d2892e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/arch/arm/include/arch/clock.h M src/arch/arm64/include/bl31.h M src/arch/arm64/ramdetect.c 3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/44201/4
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44201 )
Change subject: src/arch: Replace <types.h> with <stdint.h> ......................................................................
Patch Set 4: Code-Review-1
I disagree with this. The point of <types.h> is that developers shouldn't need to think about the inane differences in which type is defined where that we only carry around for compatibility with legacy POSIX. When I write a new file I just wanna add #include <types.h> when I need any type, and I don't see a reason to create patch churn later to replace that with something narrower.
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/44201 )
Change subject: src/arch: Replace <types.h> with <stdint.h> ......................................................................
Abandoned
-
HAOUAS Elyes (Code Review) -
Julius Werner (Code Review)