Attention is currently required from: Bora Guvendik, Anil Kumar K, Cliff Huang, Subrata Banik, Tim Wawrzynczak.
Jeremy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63942 )
Change subject: soc/intel/alderlake: support for PCIe slot & device detect timeout
......................................................................
Patch Set 6:
(2 comments)
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/63942/comment/6963ddef_1ffb2dbc
PS6, Line 671: if (!!(rp_cfg->flags & PCIE_RP_BUILT_IN))
double negation is unnecessary in a if statement.
However, you could also write it:
s_cfg->PcieRpSlotImplemented[i] = !(rp_cfg->flags & PCIE_RP_BUILT_IN)
File src/soc/intel/common/block/include/intelblocks/pcie_rp.h:
https://review.coreboot.org/c/coreboot/+/63942/comment/fec24130_2b575261
PS6, Line 30: /* indicates that this root port is built-in */
missing ending dot character.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63942
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13feb1d2d67eaba634a3e700685132fba39e1525
Gerrit-Change-Number: 63942
Gerrit-PatchSet: 6
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Cliff Huang
cliff.huang@intel.corp-partner.google.com
Gerrit-CC: Jeremy Compostella
jeremy.compostella@intel.corp-partner.google.com
Gerrit-CC: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Wed, 01 Jun 2022 04:46:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment