Change in coreboot[master]: lib: Temporarily remove timestamps from psp_verstage

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Martin Roth (Code Review)

14 Jun 2020 14 Jun '20

11:36 p.m.

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42381 )

Change subject: lib: Temporarily remove timestamps from psp_verstage ......................................................................

lib: Temporarily remove timestamps from psp_verstage

The timstamp functionality is not yet added for psp_verstage, so temporarily remove it until that's completed.

BUG=b:154142138 TEST=Build & Boot psp_verstage on trembyle

Signed-off-by: Martin Roth martin@coreboot.org Change-Id: I020619e3615ce92dedbe868104d2bfd83cb7caa9 --- M src/lib/Makefile.inc 1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/42381/1

diff --git a/src/lib/Makefile.inc b/src/lib/Makefile.inc index e0003bd..72d4f24 100644 --- a/src/lib/Makefile.inc +++ b/src/lib/Makefile.inc @@ -46,7 +46,11 @@ verstage-y += libgcc.c verstage-y += memcmp.c verstage-y += string.c + +# TODO: Remove this when PSP bootblock timestamps are implemented. +ifeq ($(CONFIG_VBOOT_STARTS_BEFORE_BOOTBLOCK),) verstage-$(CONFIG_COLLECT_TIMESTAMPS) += timestamp.c +endif verstage-y += boot_device.c verstage-$(CONFIG_CONSOLE_CBMEM) += cbmem_console.c

Attachments:

attachment.htm (text/html — 2.8 KB)

Show replies by date

Angel Pons (Code Review)

17 Jun 17 Jun

10:14 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42381 )

Change subject: lib: Temporarily remove timestamps from psp_verstage ......................................................................

Patch Set 2: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/42381/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/42381/2//COMMIT_MSG@9 PS2, Line 9: timstamp tim*e*stamp

Eric Peers (Code Review)

23 Jun 23 Jun

4:34 p.m.

Eric Peers has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42381 )

Change subject: lib: Temporarily remove timestamps from psp_verstage ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42381/2/src/lib/Makefile.inc File src/lib/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/42381/2/src/lib/Makefile.inc@50 PS2, Line 50: # TODO: Remove this when PSP bootblock timestamps are implemented. tracking bug to implement PSP timestamps?

-- To view, visit https://review.coreboot.org/c/coreboot/+/42381 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I020619e3615ce92dedbe868104d2bfd83cb7caa9 Gerrit-Change-Number: 42381 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth martinroth@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Eric Peers epeers@google.com Gerrit-Comment-Date: Tue, 23 Jun 2020 16:34:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Martin Roth (Code Review)

24 Jun 24 Jun

12:03 a.m.

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42381 )

Change subject: lib: Temporarily remove timestamps from psp_verstage ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42381/2/src/lib/Makefile.inc File src/lib/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/42381/2/src/lib/Makefile.inc@50 PS2, Line 50: # TODO: Remove this when PSP bootblock timestamps are implemented.

...

tracking bug to implement PSP timestamps?

b/154142138 Added to the commit message. I don't like adding the buganizer bugs to coreboot code since not everyone can see them.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42381 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I020619e3615ce92dedbe868104d2bfd83cb7caa9 Gerrit-Change-Number: 42381 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth martinroth@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Eric Peers epeers@google.com Gerrit-Comment-Date: Wed, 24 Jun 2020 00:03:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Peers epeers@google.com Gerrit-MessageType: comment

Martin Roth (Code Review)

6:08 a.m.

Hello build bot (Jenkins), Raul Rangel, Furquan Shaikh, Patrick Georgi, Angel Pons, Aaron Durbin,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42381

to look at the new patch set (#3).

Change subject: lib: Temporarily remove timestamps from psp_verstage ......................................................................

lib: Temporarily remove timestamps from psp_verstage

The timestamp functionality is not yet added for psp_verstage, so temporarily remove it until that's completed. That work is being tracked by bug 154142138.

BUG=b:154142138 TEST=Build & Boot psp_verstage on trembyle

Signed-off-by: Martin Roth martin@coreboot.org Change-Id: I020619e3615ce92dedbe868104d2bfd83cb7caa9 --- M src/lib/Makefile.inc 1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/42381/3

Martin Roth (Code Review)

4:21 p.m.

Hello build bot (Jenkins), Raul Rangel, Furquan Shaikh, Patrick Georgi, Angel Pons, Aaron Durbin,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42381

to look at the new patch set (#4).

Change subject: lib: Temporarily remove timestamps from psp_verstage ......................................................................

lib: Temporarily remove timestamps from psp_verstage

The timestamp functionality is not yet added for psp_verstage, so temporarily remove it until that's completed. That work is being tracked by bug 154142138.

BUG=b:154142138 TEST=Build & Boot psp_verstage on trembyle

Signed-off-by: Martin Roth martin@coreboot.org Change-Id: I020619e3615ce92dedbe868104d2bfd83cb7caa9 --- M src/lib/Makefile.inc 1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/42381/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/42381 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I020619e3615ce92dedbe868104d2bfd83cb7caa9 Gerrit-Change-Number: 42381 Gerrit-PatchSet: 4 Gerrit-Owner: Martin Roth martinroth@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Eric Peers epeers@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Felix Held (Code Review)

5:47 p.m.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42381 )

Change subject: lib: Temporarily remove timestamps from psp_verstage ......................................................................

Patch Set 4: Code-Review+2

(2 comments)

https://review.coreboot.org/c/coreboot/+/42381/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/42381/2//COMMIT_MSG@9 PS2, Line 9: timstamp

...

tim*e*stamp

Done

https://review.coreboot.org/c/coreboot/+/42381/2/src/lib/Makefile.inc File src/lib/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/42381/2/src/lib/Makefile.inc@50 PS2, Line 50: # TODO: Remove this when PSP bootblock timestamps are implemented.

...

b/154142138 […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/42381 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I020619e3615ce92dedbe868104d2bfd83cb7caa9 Gerrit-Change-Number: 42381 Gerrit-PatchSet: 4 Gerrit-Owner: Martin Roth martinroth@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Eric Peers epeers@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 24 Jun 2020 17:47:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Martin Roth martinroth@google.com Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: Eric Peers epeers@google.com Gerrit-MessageType: comment

Raul Rangel (Code Review)

25 Jun 25 Jun

8:44 p.m.

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42381 )

Change subject: lib: Temporarily remove timestamps from psp_verstage ......................................................................

Patch Set 5: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/42381 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I020619e3615ce92dedbe868104d2bfd83cb7caa9 Gerrit-Change-Number: 42381 Gerrit-PatchSet: 5 Gerrit-Owner: Martin Roth martinroth@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Eric Peers epeers@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 25 Jun 2020 20:44:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Martin Roth (Code Review)

8 Jul 8 Jul

7:37 p.m.

Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42381 )

Change subject: lib: Temporarily remove timestamps from psp_verstage ......................................................................

lib: Temporarily remove timestamps from psp_verstage

The timestamp functionality is not yet added for psp_verstage, so temporarily remove it until that's completed. That work is being tracked by bug 154142138.

BUG=b:154142138 TEST=Build & Boot psp_verstage on trembyle

Signed-off-by: Martin Roth martin@coreboot.org Change-Id: I020619e3615ce92dedbe868104d2bfd83cb7caa9 Reviewed-on: https://review.coreboot.org/c/coreboot/+/42381 Reviewed-by: Raul Rangel rrangel@chromium.org Reviewed-by: Felix Held felix-coreboot@felixheld.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/lib/Makefile.inc 1 file changed, 4 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved Raul Rangel: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/coreboot/+/42381 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I020619e3615ce92dedbe868104d2bfd83cb7caa9 Gerrit-Change-Number: 42381 Gerrit-PatchSet: 8 Gerrit-Owner: Martin Roth martinroth@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Eric Peers epeers@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1546

days inactive

1570

days old

coreboot-gerrit@coreboot.org

8 comments

5 participants

tags (0)

participants (5)

Angel Pons (Code Review)
Eric Peers (Code Review)
Felix Held (Code Review)
Martin Roth (Code Review)
Raul Rangel (Code Review)