Attention is currently required from: Felix Held, Jérémy Compostella, Karthik Ramasubramanian, Martin L Roth, Paul Menzel.
Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/84575?usp=email )
Change subject: util/lint: Use bigint for hexadecimal values in handle_range
......................................................................
Patch Set 5:
(1 comment)
File util/lint/kconfig_lint:
https://review.coreboot.org/c/coreboot/+/84575/comment/6b99609a_06728a7b?usp... :
PS4, Line 871: Use bigint for large hexadecimal values
nit: I believe this is redundant and maybe not even necessary to mention it actually.
let me remove it.
More importantly, shouldn't it make sense to also add support for default values ?
64-bit support for `default` value already existed hence, it's working over Rex64 w/o any problem.
It looks weird to me to only support large numbers for range only.
this code changes only added to support https://review.coreboot.org/c/coreboot/+/84572/4..8/src/drivers/intel/fsp2_0... where `range` is unable to handle > 32-bit value
marking it resolved as I have removed the redundant comment and `use bigint`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84575?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I402bb9bec9ba5bfb79b4185f35228c41d4a7b674
Gerrit-Change-Number: 84575
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 30 Sep 2024 18:44:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com