Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Paul Menzel, Angel Pons, Kyösti Mälkki.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57305 )
Change subject: arch/x86: Skip returning default leaf value as `0`
......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57305/comment/96af5062_e1d1e9e0
PS2, Line 11: leaf
leafs?
Ack
https://review.coreboot.org/c/coreboot/+/57305/comment/96e6bbe6_dc08f740
PS2, Line 16: e2b5fee
Please add: […]
Ack
Patchset:
PS2:
No VIA support? 😜
@Tim, can you please take a look into cpu_check_deterministic_cache_cpuid_supported(), aren't we already claim the support for Intel and AMD and anything else is considered unknown/invalid. For invalid CPUID we are returning from below code anyway.
https://review.coreboot.org/c/coreboot/+/57306/2/src/arch/x86/smbios.c#769
File src/arch/x86/cpu_common.c:
https://review.coreboot.org/c/coreboot/+/57305/comment/0343075c_9a511478
PS2, Line 115: return DETERMINISTIC_CACHE_PARAMETERS_CPUID_IA;
You could use the ternary operator.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57305
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iee33b39298e7821ac5280d998172b58a70c8715b
Gerrit-Change-Number: 57305
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Swift Geek (Sebastian Grzywna)
swiftgeek@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Thu, 02 Sep 2021 07:31:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment