Change in coreboot[master]: mb/google/drallion: Enable cbfs SAR value

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

EricR Lai (Code Review)

1 Mar 2020 1 Mar '20

8:25 p.m.

EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39194 )

Change subject: mb/google/drallion: Enable cbfs SAR value ......................................................................

mb/google/drallion: Enable cbfs SAR value

Enable read SAR value from cbfs.

BUG=b:150347463 TEST=NA

Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I5f27b6f7245669728e3e394e9c6a39c11bfda3b8 --- M src/mainboard/google/drallion/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/39194/1

diff --git a/src/mainboard/google/drallion/Kconfig b/src/mainboard/google/drallion/Kconfig index 61bae2b..3380e75 100644 --- a/src/mainboard/google/drallion/Kconfig +++ b/src/mainboard/google/drallion/Kconfig @@ -25,6 +25,7 @@ select USE_SAR select SAR_ENABLE select DSAR_ENABLE + select WIFI_SAR_CBFS

if BOARD_GOOGLE_BASEBOARD_DRALLION

Attachments:

attachment.htm (text/html — 2.3 KB)

Show replies by date

EricR Lai (Code Review)

1 Mar 1 Mar

9 p.m.

Hello Mathew King, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39194

to look at the new patch set (#2).

Change subject: mb/google/drallion: Enable cbfs SAR value ......................................................................

mb/google/drallion: Enable cbfs SAR value

Enable read SAR value from cbfs.

BUG=b:150347463 TEST=NA

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/39194/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/39194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f27b6f7245669728e3e394e9c6a39c11bfda3b8 Gerrit-Change-Number: 39194 Gerrit-PatchSet: 2 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

EricR Lai (Code Review)

9:06 p.m.

Hello Mathew King, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39194

to look at the new patch set (#3).

Change subject: mb/google/drallion: Enable cbfs SAR value ......................................................................

mb/google/drallion: Enable cbfs SAR value

Enable read SAR value from cbfs.

BUG=b:150347463 TEST=NA

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/39194/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/39194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f27b6f7245669728e3e394e9c6a39c11bfda3b8 Gerrit-Change-Number: 39194 Gerrit-PatchSet: 3 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

EricR Lai (Code Review)

9:12 p.m.

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39194 )

Change subject: mb/google/drallion: Enable cbfs SAR value ......................................................................

Patch Set 3:

@Matm how can we make builder happy? Since we don't have hex file here, we will put in chrome private...

-- To view, visit https://review.coreboot.org/c/coreboot/+/39194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f27b6f7245669728e3e394e9c6a39c11bfda3b8 Gerrit-Change-Number: 39194 Gerrit-PatchSet: 3 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 02 Mar 2020 05:12:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

EricR Lai (Code Review)

9:21 p.m.

Hello Mathew King, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39194

to look at the new patch set (#4).

Change subject: mb/google/drallion: Enable cbfs SAR value ......................................................................

mb/google/drallion: Enable cbfs SAR value

Enable read SAR value from cbfs.

BUG=b:150347463 TEST=NA

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/39194/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/39194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f27b6f7245669728e3e394e9c6a39c11bfda3b8 Gerrit-Change-Number: 39194 Gerrit-PatchSet: 4 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Paul Menzel (Code Review)

2 Mar 2 Mar

3:57 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39194 )

Change subject: mb/google/drallion: Enable cbfs SAR value ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39194/4/src/mainboard/google/dralli... File src/mainboard/google/drallion/Kconfig:

https://review.coreboot.org/c/coreboot/+/39194/4/src/mainboard/google/dralli... PS4, Line 36: config CHROMEOS_WIFI_SAR Why isn’t that symbol is some common location?

-- To view, visit https://review.coreboot.org/c/coreboot/+/39194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f27b6f7245669728e3e394e9c6a39c11bfda3b8 Gerrit-Change-Number: 39194 Gerrit-PatchSet: 4 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 02 Mar 2020 11:57:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

EricR Lai (Code Review)

4:16 a.m.

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39194 )

Change subject: mb/google/drallion: Enable cbfs SAR value ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39194/4/src/mainboard/google/dralli... File src/mainboard/google/drallion/Kconfig:

https://review.coreboot.org/c/coreboot/+/39194/4/src/mainboard/google/dralli... PS4, Line 36: config CHROMEOS_WIFI_SAR

...

Why isn’t that symbol is some common location?

It will effect all chrome boards... You can see patch3. I followed the Hatch board to config this and it be fine now.

-- To view, visit https://review.coreboot.org/c/coreboot/+/39194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f27b6f7245669728e3e394e9c6a39c11bfda3b8 Gerrit-Change-Number: 39194 Gerrit-PatchSet: 4 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 02 Mar 2020 12:16:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Ivy Jian (Code Review)

10:21 p.m.

Ivy Jian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39194 )

Change subject: mb/google/drallion: Enable cbfs SAR value ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/39194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f27b6f7245669728e3e394e9c6a39c11bfda3b8 Gerrit-Change-Number: 39194 Gerrit-PatchSet: 4 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 03 Mar 2020 06:21:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

3 Mar 3 Mar

2:19 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39194 )

Change subject: mb/google/drallion: Enable cbfs SAR value ......................................................................

mb/google/drallion: Enable cbfs SAR value

Enable read SAR value from cbfs.

BUG=b:150347463 TEST=NA

Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I5f27b6f7245669728e3e394e9c6a39c11bfda3b8 Reviewed-on: https://review.coreboot.org/c/coreboot/+/39194 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Ivy Jian ivy_jian@compal.corp-partner.google.com --- M src/mainboard/google/drallion/Kconfig 1 file changed, 8 insertions(+), 3 deletions(-)

Approvals: build bot (Jenkins): Verified Ivy Jian: Looks good to me, approved

diff --git a/src/mainboard/google/drallion/Kconfig b/src/mainboard/google/drallion/Kconfig index 61bae2b..aff19c8 100644 --- a/src/mainboard/google/drallion/Kconfig +++ b/src/mainboard/google/drallion/Kconfig @@ -22,9 +22,6 @@ select SYSTEM_TYPE_LAPTOP select TPM2 select MAINBOARD_USES_IFD_EC_REGION - select USE_SAR - select SAR_ENABLE - select DSAR_ENABLE

if BOARD_GOOGLE_BASEBOARD_DRALLION

@@ -36,6 +33,14 @@ select GBB_FLAG_FORCE_DEV_BOOT_LEGACY select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC

+config CHROMEOS_WIFI_SAR + bool "Enable SAR options for Chrome OS build" + depends on CHROMEOS + select DSAR_ENABLE + select SAR_ENABLE + select USE_SAR + select WIFI_SAR_CBFS + config DIMM_MAX int default 2

-- To view, visit https://review.coreboot.org/c/coreboot/+/39194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f27b6f7245669728e3e394e9c6a39c11bfda3b8 Gerrit-Change-Number: 39194 Gerrit-PatchSet: 5 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1719

days inactive

1720

days old

coreboot-gerrit@coreboot.org

8 comments

4 participants

tags (0)

participants (4)

EricR Lai (Code Review)
Ivy Jian (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)