Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49109 )
Change subject: mb/google/zork: update stamp_boost parameter for dirinboz ......................................................................
mb/google/zork: update stamp_boost parameter for dirinboz
For balance performance and skin temperature, update stapm_time_constant_s: 2500 -> 1640
BUG=b:175364713 TEST=emerge-zork coreboot
Change-Id: I44f086af6b5dd552efd2bd1ef4db0d69b652826d Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M src/mainboard/google/zork/variants/dirinboz/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/49109/1
diff --git a/src/mainboard/google/zork/variants/dirinboz/overridetree.cb b/src/mainboard/google/zork/variants/dirinboz/overridetree.cb index efd1dfc..3032984 100644 --- a/src/mainboard/google/zork/variants/dirinboz/overridetree.cb +++ b/src/mainboard/google/zork/variants/dirinboz/overridetree.cb @@ -12,7 +12,7 @@ register "slow_ppt_limit_mW" = "6000" register "fast_ppt_limit_mW" = "9000" register "slow_ppt_time_constant_s" = "5" - register "stapm_time_constant_s" = "2500" + register "stapm_time_constant_s" = "1640" register "sustained_power_limit_mW" = "4800"
register "telemetry_vddcr_vdd_slope_mA" = "42465"
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49109 )
Change subject: mb/google/zork: update stamp_boost parameter for dirinboz ......................................................................
Patch Set 1: Code-Review+1
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49109 )
Change subject: mb/google/zork: update stamp_boost parameter for dirinboz ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/49109/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/49109/1//COMMIT_MSG@7 PS1, Line 7: update Decrease
https://review.coreboot.org/c/coreboot/+/49109/1//COMMIT_MSG@10 PS1, Line 10: update decrease
(and also fits on line above)
https://review.coreboot.org/c/coreboot/+/49109/1//COMMIT_MSG@11 PS1, Line 11: 2500 -> 1640 Where did you get the new value from?
https://review.coreboot.org/c/coreboot/+/49109/1//COMMIT_MSG@15 PS1, Line 15: Tested how?
Hello build bot (Jenkins), Martin Roth, Furquan Shaikh, Bhanu Prakash Maiya, Rob Barnes, Eric Peers, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49109
to look at the new patch set (#2).
Change subject: mb/google/zork: Decrease stamp_boost parameter for dirinboz ......................................................................
mb/google/zork: Decrease stamp_boost parameter for dirinboz
Original Stamp_boost parameter will cause boost time over 2500sec(3960sec) To pass balance performance and skin temperature test, decrease stamp_boost: 2500 -> 1640
BUG=b:175364713 TEST=1. emerge-zork coreboot 2. run balance performance and skin temperature test
Change-Id: I44f086af6b5dd552efd2bd1ef4db0d69b652826d Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M src/mainboard/google/zork/variants/dirinboz/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/49109/2
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49109 )
Change subject: mb/google/zork: Decrease stamp_boost parameter for dirinboz ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/49109/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/49109/1//COMMIT_MSG@7 PS1, Line 7: update
Decrease
Done
https://review.coreboot.org/c/coreboot/+/49109/1//COMMIT_MSG@10 PS1, Line 10: update
decrease […]
Done
https://review.coreboot.org/c/coreboot/+/49109/1//COMMIT_MSG@11 PS1, Line 11: 2500 -> 1640
Where did you get the new value from?
fine tune value from thermal team.
https://review.coreboot.org/c/coreboot/+/49109/1//COMMIT_MSG@15 PS1, Line 15:
Tested how?
Done
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49109 )
Change subject: mb/google/zork: Decrease stamp_boost parameter for dirinboz ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/49109/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/49109/1//COMMIT_MSG@11 PS1, Line 11: 2500 -> 1640
fine tune value from thermal team.
Done
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49109 )
Change subject: mb/google/zork: Decrease stamp_boost parameter for dirinboz ......................................................................
Patch Set 2: Code-Review+2
looks good to me, but i wonder why the build fails; seems to be unrelated to the patch
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49109 )
Change subject: mb/google/zork: Decrease stamp_boost parameter for dirinboz ......................................................................
mb/google/zork: Decrease stamp_boost parameter for dirinboz
Original Stamp_boost parameter will cause boost time over 2500sec(3960sec) To pass balance performance and skin temperature test, decrease stamp_boost: 2500 -> 1640
BUG=b:175364713 TEST=1. emerge-zork coreboot 2. run balance performance and skin temperature test
Change-Id: I44f086af6b5dd552efd2bd1ef4db0d69b652826d Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/49109 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de Reviewed-by: Rob Barnes robbarnes@google.com --- M src/mainboard/google/zork/variants/dirinboz/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved Rob Barnes: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/zork/variants/dirinboz/overridetree.cb b/src/mainboard/google/zork/variants/dirinboz/overridetree.cb index efd1dfc..3032984 100644 --- a/src/mainboard/google/zork/variants/dirinboz/overridetree.cb +++ b/src/mainboard/google/zork/variants/dirinboz/overridetree.cb @@ -12,7 +12,7 @@ register "slow_ppt_limit_mW" = "6000" register "fast_ppt_limit_mW" = "9000" register "slow_ppt_time_constant_s" = "5" - register "stapm_time_constant_s" = "2500" + register "stapm_time_constant_s" = "1640" register "sustained_power_limit_mW" = "4800"
register "telemetry_vddcr_vdd_slope_mA" = "42465"
-
Felix Held (Code Review) -
Kevin Chiu (Code Review)
-
Paul Menzel (Code Review)
-
Rob Barnes (Code Review)