Attention is currently required from: Marc Jones.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52160 )
Change subject: soc/intel/xeon_sp: Set MSR locks
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52160/comment/faed4645_b104b2c5
PS2, Line 11: MSR_FEATURE_CONFIG
This is already done during the CPU init. Doing it again causes exception errors.
https://review.coreboot.org/c/coreboot/+/52160/comment/84e35d5b_bf109fa1
PS2, Line 12: TURBO_ACTIVATION_RATIO_LOCK
Any reason to do this here with PARALLEL_MP_AP_WORK instead of during the CPU init?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52160
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iacf495f0880d42b378cb0d2c37940d50a511c430
Gerrit-Change-Number: 52160
Gerrit-PatchSet: 2
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Comment-Date: Mon, 31 May 2021 13:40:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment