Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54065 )
Change subject: amd/cezanne: adding support for the changed AMD FSP API for USB PHY ......................................................................
Patch Set 6:
(4 comments)
File src/soc/amd/cezanne/fsp_m_params.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119269): https://review.coreboot.org/c/coreboot/+/54065/comment/51b29545_8517ebe5 PS6, Line 131: if (config->usb_phy_custom) { suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119269): https://review.coreboot.org/c/coreboot/+/54065/comment/ff60381b_51d2f455 PS6, Line 131: if (config->usb_phy_custom) { braces {} are not necessary for any arm of this statement
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119269): https://review.coreboot.org/c/coreboot/+/54065/comment/3cceb533_eb8140c9 PS6, Line 134: else { suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119269): https://review.coreboot.org/c/coreboot/+/54065/comment/c1555879_d0c601e1 PS6, Line 134: else { else should follow close brace '}'