Wim Vervoorn has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36851 )
Change subject: src: Move vendorcode menu from chipset to last menu ......................................................................
src: Move vendorcode menu from chipset to last menu
Move the vendorcode menu from the chipset menu to a seperate item.
BUG=N/A TEST=build
Change-Id: I3b2aa3836e8d9a3242c6d1f3ba7b7821a5cfb9d3 Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/Kconfig 1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/36851/1
diff --git a/src/Kconfig b/src/Kconfig index 56ebe82..971da15 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -444,7 +444,6 @@ source "src/ec/*/*/Kconfig"
source "src/southbridge/intel/common/firmware/Kconfig" -source "src/vendorcode/*/Kconfig"
source "src/arch/*/Kconfig"
@@ -1082,6 +1081,11 @@
endmenu
+menu "Vendorcode" + +source "src/vendorcode/*/Kconfig" + +endmenu
############################################################################### # Set variables with no prompt - these can be set anywhere, and putting at
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36851 )
Change subject: src: Move vendorcode menu from chipset to last menu ......................................................................
Patch Set 1: Code-Review+1
Makes sense but I don't know the reasons why it was placed in Chipset. Also, why does vendorcode have visible options?
Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36851 )
Change subject: src: Move vendorcode menu from chipset to last menu ......................................................................
Patch Set 1:
Patch Set 1: Code-Review+1
Makes sense but I don't know the reasons why it was placed in Chipset. Also, why does vendorcode have visible options?
I have no clue why it was in chipset.
We have visible options as the eltan security features need configuration. This menu however will only be visible if the option is selected on board level. So it will only show up when supported by the board.
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36851 )
Change subject: src: Move vendorcode menu from chipset to last menu ......................................................................
Patch Set 1:
I believe it was placed where it was placed because ordering unfortunately matters in the evaluation of Kconfig options.
Hello Werner Zeh, Patrick Rudolph, Frans Hendriks, Philipp Deppenwiese, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36851
to look at the new patch set (#3).
Change subject: vendorcode/eltan/security: Move eltan security from chipset to security menu ......................................................................
vendorcode/eltan/security: Move eltan security from chipset to security menu
The eltan security items ended up in the chipset menu which is not desired. Now the eltan security option (when enabled in mainboard) shows up in the security menu.
BUG=N/A TEST=build
Change-Id: I3b2aa3836e8d9a3242c6d1f3ba7b7821a5cfb9d3 Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/Kconfig D src/vendorcode/eltan/Kconfig M src/vendorcode/eltan/security/Kconfig 3 files changed, 10 insertions(+), 21 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/36851/3
Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36851 )
Change subject: vendorcode/eltan/security: Move eltan security from chipset to security menu ......................................................................
Patch Set 3:
Patch Set 1:
I believe it was placed where it was placed because ordering unfortunately matters in the evaluation of Kconfig options.
I had a new look at it. To avoid any risk the vendorcode menu is left where it was in the chipset area. The vendorcode/eltan/Kconfig is removed is it doesn't show up in the chipset menu any longer. I added the vendorcode/eltan/security/Kconfig to the security menu so it conditionally shows up.
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36851 )
Change subject: vendorcode/eltan/security: Move eltan security from chipset to security menu ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36851 )
Change subject: vendorcode/eltan/security: Move eltan security from chipset to security menu ......................................................................
vendorcode/eltan/security: Move eltan security from chipset to security menu
The eltan security items ended up in the chipset menu which is not desired. Now the eltan security option (when enabled in mainboard) shows up in the security menu.
BUG=N/A TEST=build
Change-Id: I3b2aa3836e8d9a3242c6d1f3ba7b7821a5cfb9d3 Signed-off-by: Wim Vervoorn wvervoorn@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/36851 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Frans Hendriks fhendriks@eltan.com --- M src/Kconfig D src/vendorcode/eltan/Kconfig M src/vendorcode/eltan/security/Kconfig 3 files changed, 10 insertions(+), 21 deletions(-)
Approvals: build bot (Jenkins): Verified Frans Hendriks: Looks good to me, approved
diff --git a/src/Kconfig b/src/Kconfig index 56ebe82..ba9ae86 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -461,6 +461,7 @@ menu "Security"
source "src/security/Kconfig" +source "src/vendorcode/eltan/security/Kconfig"
endmenu
diff --git a/src/vendorcode/eltan/Kconfig b/src/vendorcode/eltan/Kconfig deleted file mode 100644 index 30bb8b8..0000000 --- a/src/vendorcode/eltan/Kconfig +++ /dev/null @@ -1,21 +0,0 @@ -## -## This file is part of the coreboot project. -## -## Copyright (C) 2019 Eltan B.V. -## -## This program is free software; you can redistribute it and/or modify -## it under the terms of the GNU General Public License as published by -## the Free Software Foundation; version 2 of the License. -## -## This program is distributed in the hope that it will be useful, -## but WITHOUT ANY WARRANTY; without even the implied warranty of -## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -## GNU General Public License for more details. -## - -config USE_VENDORCODE_ELTAN - bool - -if USE_VENDORCODE_ELTAN -source src/vendorcode/eltan/security/Kconfig -endif diff --git a/src/vendorcode/eltan/security/Kconfig b/src/vendorcode/eltan/security/Kconfig index 6b93d2a..1cc0365 100644 --- a/src/vendorcode/eltan/security/Kconfig +++ b/src/vendorcode/eltan/security/Kconfig @@ -12,7 +12,16 @@ ## GNU General Public License for more details. ##
+config USE_VENDORCODE_ELTAN + bool + +if USE_VENDORCODE_ELTAN + menu "Eltan Security Settings" + source src/vendorcode/eltan/security/mboot/Kconfig source src/vendorcode/eltan/security/verified_boot/Kconfig + endmenu + +endif
-
Frans Hendriks (Code Review) -
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)
-
Stefan Reinauer (Code Review)
-
Wim Vervoorn (Code Review)