Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45877 )
Change subject: acpi: Skip writing references for disabled devices in Type-C config ......................................................................
acpi: Skip writing references for disabled devices in Type-C config
When emitting ACPI tables for the Type-C connector class, skip writing out a device reference if it is to a disabled device.
Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Change-Id: I84cc3e1a54e2b654239ad6e1a4662d582f3465cf --- M src/acpi/acpigen_usb.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/45877/1
diff --git a/src/acpi/acpigen_usb.c b/src/acpi/acpigen_usb.c index 90a9b77..7448b3b 100644 --- a/src/acpi/acpigen_usb.c +++ b/src/acpi/acpigen_usb.c @@ -71,7 +71,7 @@ const char *path; char *fresh;
- if (!dev) + if (!dev || !dev->enabled) return;
/*
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45877 )
Change subject: acpi: Skip writing references for disabled devices in Type-C config ......................................................................
Patch Set 1: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45877 )
Change subject: acpi: Skip writing references for disabled devices in Type-C config ......................................................................
Patch Set 1: Code-Review+2
Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45877 )
Change subject: acpi: Skip writing references for disabled devices in Type-C config ......................................................................
acpi: Skip writing references for disabled devices in Type-C config
When emitting ACPI tables for the Type-C connector class, skip writing out a device reference if it is to a disabled device.
Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Change-Id: I84cc3e1a54e2b654239ad6e1a4662d582f3465cf Reviewed-on: https://review.coreboot.org/c/coreboot/+/45877 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Duncan Laurie dlaurie@chromium.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/acpi/acpigen_usb.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved Furquan Shaikh: Looks good to me, approved
diff --git a/src/acpi/acpigen_usb.c b/src/acpi/acpigen_usb.c index 90a9b77..7448b3b 100644 --- a/src/acpi/acpigen_usb.c +++ b/src/acpi/acpigen_usb.c @@ -71,7 +71,7 @@ const char *path; char *fresh;
- if (!dev) + if (!dev || !dev->enabled) return;
/*