Change in coreboot[master]: tests/Makefile.inc: Correct dependency file suffix - coreboot-gerrit

20 Jul 2021


      Attention is currently required from: Jakub Czapiga, Julius Werner.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56444 )
Change subject: tests/Makefile.inc: Correct dependency file suffix
......................................................................
Patch Set 1:
(1 comment)
File tests/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/56444/comment/5cc95db9_6f0cd1e1 
PS1, Line 145: DEPENDENCIES += $(addsuffix .d,$(all-test-objs))
I'm not sure if we should correct the path here, or fix the recipe like this:
$(HOSTCC) ... -o $$@
 mv -f $$@ $$@.orig
 $(OBJCOPY) $$@.orig $$(OBJCOPY_FLAGS) $$@
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/56444
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I01f77ebaaae78dd9e69394a49e524f1013857195
Gerrit-Change-Number: 56444
Gerrit-PatchSet: 1
Gerrit-Owner: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: Jakub Czapiga jacz@semihalf.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Jakub Czapiga jacz@semihalf.com
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Comment-Date: Tue, 20 Jul 2021 06:53:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment