Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50466 )
Change subject: soc/amd: fully commonize clear_tvalid
......................................................................
Patch Set 5:
(1 comment)
File src/soc/amd/common/block/cpu/smm/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/50466/comment/38e97ff9_4745af8b
PS5, Line 5: romstage-y += smm_helper.c
: postcar-y += smm_helper.c
stoneyridge uses it there and not adding it will break the build. […]
*many
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50466
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I90526a566a5fbc19a7368f90421067a6c716614e
Gerrit-Change-Number: 50466
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Comment-Date: Wed, 10 Feb 2021 18:12:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment