Wim Vervoorn has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37836 )
Change subject: mb/facebook/fbg1701: Correct typo in hda verbs ......................................................................
mb/facebook/fbg1701: Correct typo in hda verbs
The MIC1 NID is configured incorrectly because of a typo. The value is 7 digits instead of 8 this is corrected by this patch.
No issues are known because of this (the MIC is not connected).
BUG=N/A TEST=build
Change-Id: Ia12f3be7d7262829cce3400a8535a33ea1c54b78 Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/mainboard/facebook/fbg1701/hda_verb.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/37836/1
diff --git a/src/mainboard/facebook/fbg1701/hda_verb.c b/src/mainboard/facebook/fbg1701/hda_verb.c index 344443f..5cf820d 100644 --- a/src/mainboard/facebook/fbg1701/hda_verb.c +++ b/src/mainboard/facebook/fbg1701/hda_verb.c @@ -45,7 +45,7 @@ AZALIA_PIN_CFG(0x0, 0x17, 0x01011120),
/* Pin Complex (NID 0x18) MIC1 (Port-B) */ - AZALIA_PIN_CFG(0x0, 0x18, 0x41111F0), + AZALIA_PIN_CFG(0x0, 0x18, 0x411111F0),
/* Pin Complex (NID 0x19) I2S-IN */ AZALIA_PIN_CFG(0x0, 0x19, 0x90870140),
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37836 )
Change subject: mb/facebook/fbg1701: Correct typo in hda verbs ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/37836/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37836/2//COMMIT_MSG@10 PS2, Line 10: 8 this Nit: Full stop here?
... instead of 8. This is corrected ...
Hello Angel Pons, Frans Hendriks, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37836
to look at the new patch set (#3).
Change subject: mb/facebook/fbg1701: Correct typo in hda verbs ......................................................................
mb/facebook/fbg1701: Correct typo in hda verbs
The MIC1 NID is configured incorrectly because of a typo. The value is 7 digits instead of 8. This is corrected by this patch.
No issues are known because of this (the MIC is not connected).
BUG=N/A TEST=build
Change-Id: Ia12f3be7d7262829cce3400a8535a33ea1c54b78 Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/mainboard/facebook/fbg1701/hda_verb.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/37836/3
Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37836 )
Change subject: mb/facebook/fbg1701: Correct typo in hda verbs ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37836/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37836/2//COMMIT_MSG@10 PS2, Line 10: 8 this
Nit: Full stop here? […]
Done
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37836 )
Change subject: mb/facebook/fbg1701: Correct typo in hda verbs ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37836 )
Change subject: mb/facebook/fbg1701: Correct typo in hda verbs ......................................................................
mb/facebook/fbg1701: Correct typo in hda verbs
The MIC1 NID is configured incorrectly because of a typo. The value is 7 digits instead of 8. This is corrected by this patch.
No issues are known because of this (the MIC is not connected).
BUG=N/A TEST=build
Change-Id: Ia12f3be7d7262829cce3400a8535a33ea1c54b78 Signed-off-by: Wim Vervoorn wvervoorn@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37836 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Frans Hendriks fhendriks@eltan.com Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/facebook/fbg1701/hda_verb.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Frans Hendriks: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/facebook/fbg1701/hda_verb.c b/src/mainboard/facebook/fbg1701/hda_verb.c index 344443f..5cf820d 100644 --- a/src/mainboard/facebook/fbg1701/hda_verb.c +++ b/src/mainboard/facebook/fbg1701/hda_verb.c @@ -45,7 +45,7 @@ AZALIA_PIN_CFG(0x0, 0x17, 0x01011120),
/* Pin Complex (NID 0x18) MIC1 (Port-B) */ - AZALIA_PIN_CFG(0x0, 0x18, 0x41111F0), + AZALIA_PIN_CFG(0x0, 0x18, 0x411111F0),
/* Pin Complex (NID 0x19) I2S-IN */ AZALIA_PIN_CFG(0x0, 0x19, 0x90870140),
-
Angel Pons (Code Review) -
Frans Hendriks (Code Review)
-
Patrick Georgi (Code Review)
-
Wim Vervoorn (Code Review)