Change in coreboot[master]: cpu/x86/name/name.c: Clean up includes

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Change in coreboot[master]: src:...

HAOUAS Elyes (Code Review)

9 Aug 2020 9 Aug '20

6:57 p.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44315 )

Change subject: cpu/x86/name/name.c: Clean up includes ......................................................................

cpu/x86/name/name.c: Clean up includes

Change-Id: I49615434b140601ce599b4a63aa42c82874bd0f7 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/cpu/x86/name/name.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/44315/1

diff --git a/src/cpu/x86/name/name.c b/src/cpu/x86/name/name.c index a7d2c70..d4f50b6 100644 --- a/src/cpu/x86/name/name.c +++ b/src/cpu/x86/name/name.c @@ -2,8 +2,8 @@

#include <string.h> #include <arch/cpu.h> -#include <device/device.h> #include <cpu/x86/name.h> +#include <stdint.h>

void fill_processor_name(char *processor_name) {

Attachments:

attachment.htm (text/html — 2.3 KB)

Show replies by date

Angel Pons (Code Review)

31 Jan 31 Jan

10:33 p.m.

Attention is currently required from: HAOUAS Elyes. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44315 )

Change subject: cpu/x86/name/name.c: Clean up includes ......................................................................

Patch Set 7: Code-Review+1

(1 comment)

File src/cpu/x86/name/name.c:

https://review.coreboot.org/c/coreboot/+/44315/comment/7cf1e053_a2298caf PS7, Line 3: #include <string.h> Also sort this one alphabetically?

-- To view, visit https://review.coreboot.org/c/coreboot/+/44315 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I49615434b140601ce599b4a63aa42c82874bd0f7 Gerrit-Change-Number: 44315 Gerrit-PatchSet: 7 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: HAOUAS Elyes ehaouas@noos.fr Gerrit-Comment-Date: Sun, 31 Jan 2021 11:33:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

11:21 p.m.

Attention is currently required from: Angel Pons. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44315 )

Change subject: cpu/x86/name/name.c: Clean up includes ......................................................................

Patch Set 8:

(1 comment)

File src/cpu/x86/name/name.c:

https://review.coreboot.org/c/coreboot/+/44315/comment/3836ebe7_ba5fa310 PS7, Line 3: #include <string.h>

...

Also sort this one alphabetically?

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/44315 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I49615434b140601ce599b4a63aa42c82874bd0f7 Gerrit-Change-Number: 44315 Gerrit-PatchSet: 8 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Sun, 31 Jan 2021 12:21:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Angel Pons (Code Review)

11:26 p.m.

Attention is currently required from: HAOUAS Elyes. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44315 )

Change subject: cpu/x86/name/name.c: Clean up includes ......................................................................

Patch Set 8: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/44315 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I49615434b140601ce599b4a63aa42c82874bd0f7 Gerrit-Change-Number: 44315 Gerrit-PatchSet: 8 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: HAOUAS Elyes ehaouas@noos.fr Gerrit-Comment-Date: Sun, 31 Jan 2021 12:26:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

1 Feb 1 Feb

8:02 p.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44315 )

Change subject: cpu/x86/name/name.c: Clean up includes ......................................................................

cpu/x86/name/name.c: Clean up includes

Also sort includes alphabetically.

Change-Id: I49615434b140601ce599b4a63aa42c82874bd0f7 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/44315 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/cpu/x86/name/name.c 1 file changed, 2 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved

diff --git a/src/cpu/x86/name/name.c b/src/cpu/x86/name/name.c index a7d2c70..bf62aef 100644 --- a/src/cpu/x86/name/name.c +++ b/src/cpu/x86/name/name.c @@ -1,9 +1,9 @@ /* SPDX-License-Identifier: GPL-2.0-only */

-#include <string.h> #include <arch/cpu.h> -#include <device/device.h> #include <cpu/x86/name.h> +#include <stdint.h> +#include <string.h>

void fill_processor_name(char *processor_name) {

-- To view, visit https://review.coreboot.org/c/coreboot/+/44315 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I49615434b140601ce599b4a63aa42c82874bd0f7 Gerrit-Change-Number: 44315 Gerrit-PatchSet: 9 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1344

days inactive

1520

days old

coreboot-gerrit@coreboot.org

4 comments

3 participants

tags (0)

participants (3)

Angel Pons (Code Review)
HAOUAS Elyes (Code Review)
Patrick Georgi (Code Review)