Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32258
Change subject: soc/intel/cannonlake: Do not use XIP_ROM_SIZE ......................................................................
soc/intel/cannonlake: Do not use XIP_ROM_SIZE
XIP_ROM_SIZE Kconfig option isn't used on Cannon Lake and family. Thus, this change selects NO_FIXED_XIP_ROM_SIZE to indicate to build system so that romstage can be placed in less rigid manner.
BUG=b:129802811
Change-Id: I5f3786396246c89b1039ba1b6b332a32e6a0345d Signed-off-by: Furquan Shaikh furquan@google.com --- M src/soc/intel/cannonlake/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/32258/1
diff --git a/src/soc/intel/cannonlake/Kconfig b/src/soc/intel/cannonlake/Kconfig index 9796546..55fef5a 100644 --- a/src/soc/intel/cannonlake/Kconfig +++ b/src/soc/intel/cannonlake/Kconfig @@ -70,6 +70,7 @@ select INTEL_GMA_ADD_VBT if RUN_FSP_GOP select IOAPIC select MRC_SETTINGS_PROTECT + select NO_FIXED_XIP_ROM_SIZE select PARALLEL_MP select PARALLEL_MP_AP_WORK select PLATFORM_USES_FSP2_0
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32258 )
Change subject: soc/intel/cannonlake: Do not use XIP_ROM_SIZE ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32258 )
Change subject: soc/intel/cannonlake: Do not use XIP_ROM_SIZE ......................................................................
Patch Set 1: Code-Review+1
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32258 )
Change subject: soc/intel/cannonlake: Do not use XIP_ROM_SIZE ......................................................................
Patch Set 1: Code-Review+2
While we are at it, should cannonlake/ select FSP_M_XIP? I've never understood why this has a user prompt.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32258 )
Change subject: soc/intel/cannonlake: Do not use XIP_ROM_SIZE ......................................................................
Patch Set 1:
While we are at it, should cannonlake/ select FSP_M_XIP?
Good point. Yes, that needs to be done. Let me push a patch for it and test it out.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32258 )
Change subject: soc/intel/cannonlake: Do not use XIP_ROM_SIZE ......................................................................
Patch Set 1:
Patch Set 1:
While we are at it, should cannonlake/ select FSP_M_XIP?
Good point. Yes, that needs to be done. Let me push a patch for it and test it out.
https://review.coreboot.org/c/coreboot/+/32275/1
Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32258 )
Change subject: soc/intel/cannonlake: Do not use XIP_ROM_SIZE ......................................................................
soc/intel/cannonlake: Do not use XIP_ROM_SIZE
XIP_ROM_SIZE Kconfig option isn't used on Cannon Lake and family. Thus, this change selects NO_FIXED_XIP_ROM_SIZE to indicate to build system so that romstage can be placed in less rigid manner.
BUG=b:129802811
Change-Id: I5f3786396246c89b1039ba1b6b332a32e6a0345d Signed-off-by: Furquan Shaikh furquan@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32258 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Duncan Laurie dlaurie@chromium.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Nico Huber nico.h@gmx.de --- M src/soc/intel/cannonlake/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved Nico Huber: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve
diff --git a/src/soc/intel/cannonlake/Kconfig b/src/soc/intel/cannonlake/Kconfig index 9796546..55fef5a 100644 --- a/src/soc/intel/cannonlake/Kconfig +++ b/src/soc/intel/cannonlake/Kconfig @@ -70,6 +70,7 @@ select INTEL_GMA_ADD_VBT if RUN_FSP_GOP select IOAPIC select MRC_SETTINGS_PROTECT + select NO_FIXED_XIP_ROM_SIZE select PARALLEL_MP select PARALLEL_MP_AP_WORK select PLATFORM_USES_FSP2_0
-
Duncan Laurie (Code Review) -
Furquan Shaikh (Code Review)
-
Nico Huber (Code Review)
-
Paul Menzel (Code Review)