Change in coreboot[master]: mb/google/kahlee/nuwani: support new Elan touch panel for Nuwani
Tommie Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39494 )
Change subject: mb/google/kahlee/nuwani: support new Elan touch panel for Nuwani ......................................................................
mb/google/kahlee/nuwani: support new Elan touch panel for Nuwani
This is new Elan touch screen IC, which includes touch panel and USI pen.
BUG=None TEST=build bios and verify touch screen works fine
Signed-off-by: Tommie Lin tong.lin@bitland.corp-partner.google.com Change-Id: I98801b8c31812637f71d7eaaa0f12b47901dc47a --- M src/mainboard/google/kahlee/variants/nuwani/devicetree.cb 1 file changed, 13 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/39494/1
diff --git a/src/mainboard/google/kahlee/variants/nuwani/devicetree.cb b/src/mainboard/google/kahlee/variants/nuwani/devicetree.cb index 6c953b1..689e604 100644 --- a/src/mainboard/google/kahlee/variants/nuwani/devicetree.cb +++ b/src/mainboard/google/kahlee/variants/nuwani/devicetree.cb @@ -156,6 +156,19 @@ end device mmio 0xfedc5000 on chip drivers/i2c/hid + register "generic.hid" = ""ELAN90FC"" + register "generic.desc" = ""ELAN Touchscreen"" + register "generic.irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_11)" + register "generic.probed" = "1" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_85)" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_76)" + register "generic.reset_delay_ms" = "20" + register "generic.has_power_resource" = "1" + register "generic.disable_gpio_export_in_crs" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 10 on end + end + chip drivers/i2c/hid register "generic.hid" = ""SYTS7817"" register "generic.desc" = ""Synaptics Touchscreen"" register "generic.irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_11)"
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39494
to look at the new patch set (#2).
Change subject: mb/google/kahlee/nuwani: support new Elan touch panel for Nuwani ......................................................................
mb/google/kahlee/nuwani: support new Elan touch panel for Nuwani
This is new Elan touch screen IC, which includes touch panel and USI pen.
BUG=151514167 TEST=build bios and verify touch screen works fine
Signed-off-by: Tommie Lin tong.lin@bitland.corp-partner.google.com Change-Id: I98801b8c31812637f71d7eaaa0f12b47901dc47a --- M src/mainboard/google/kahlee/variants/nuwani/devicetree.cb 1 file changed, 13 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/39494/2
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39494
to look at the new patch set (#3).
Change subject: mb/google/kahlee/nuwani: support new Elan touch panel for Nuwani ......................................................................
mb/google/kahlee/nuwani: support new Elan touch panel for Nuwani
This is new Elan touch screen IC, which includes touch panel and USI pen.
BUG=b:151514167 TEST=build bios and verify touch screen works fine
Signed-off-by: Tommie Lin tong.lin@bitland.corp-partner.google.com Change-Id: I98801b8c31812637f71d7eaaa0f12b47901dc47a --- M src/mainboard/google/kahlee/variants/nuwani/devicetree.cb 1 file changed, 13 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/39494/3
Hello build bot (Jenkins), Martin Roth, Peichao Li,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39494
to look at the new patch set (#4).
Change subject: mb/google/kahlee/nuwani: support new Elan touch panel for Nuwani ......................................................................
mb/google/kahlee/nuwani: support new Elan touch panel for Nuwani
This is new Elan touch screen IC, which includes touch panel and USI pen.
BUG=b:151514167 TEST=build bios and verify touch screen works fine
Signed-off-by: Tommie Lin tong.lin@bitland.corp-partner.google.com Change-Id: I98801b8c31812637f71d7eaaa0f12b47901dc47a --- M src/mainboard/google/kahlee/variants/nuwani/devicetree.cb 1 file changed, 13 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/39494/4
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39494 )
Change subject: mb/google/kahlee/nuwani: support new Elan touch panel for Nuwani ......................................................................
Patch Set 4: Code-Review+2
Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39494 )
Change subject: mb/google/kahlee/nuwani: support new Elan touch panel for Nuwani ......................................................................
mb/google/kahlee/nuwani: support new Elan touch panel for Nuwani
This is new Elan touch screen IC, which includes touch panel and USI pen.
BUG=b:151514167 TEST=build bios and verify touch screen works fine
Signed-off-by: Tommie Lin tong.lin@bitland.corp-partner.google.com Change-Id: I98801b8c31812637f71d7eaaa0f12b47901dc47a Reviewed-on: https://review.coreboot.org/c/coreboot/+/39494 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com --- M src/mainboard/google/kahlee/variants/nuwani/devicetree.cb 1 file changed, 13 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved
diff --git a/src/mainboard/google/kahlee/variants/nuwani/devicetree.cb b/src/mainboard/google/kahlee/variants/nuwani/devicetree.cb index 6c953b1..689e604 100644 --- a/src/mainboard/google/kahlee/variants/nuwani/devicetree.cb +++ b/src/mainboard/google/kahlee/variants/nuwani/devicetree.cb @@ -156,6 +156,19 @@ end device mmio 0xfedc5000 on chip drivers/i2c/hid + register "generic.hid" = ""ELAN90FC"" + register "generic.desc" = ""ELAN Touchscreen"" + register "generic.irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_11)" + register "generic.probed" = "1" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_85)" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_76)" + register "generic.reset_delay_ms" = "20" + register "generic.has_power_resource" = "1" + register "generic.disable_gpio_export_in_crs" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 10 on end + end + chip drivers/i2c/hid register "generic.hid" = ""SYTS7817"" register "generic.desc" = ""Synaptics Touchscreen"" register "generic.irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_11)"
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39494 )
Change subject: mb/google/kahlee/nuwani: support new Elan touch panel for Nuwani ......................................................................
Patch Set 5:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/1360 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1359 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1358
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Martin Roth (Code Review)
-
Tommie Lin (Code Review)