Nathan Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32335
Change subject: mb/google/arcada: Set psys_pmax to 140W ......................................................................
mb/google/arcada: Set psys_pmax to 140W
arcada is designed to operate at max power of 140 Watt. Hence set psys_max to 140W.
BUG=b:124792558 BRANCH=None TEST=Build and boot arcada.
Change-Id: I280dfb81b3e25c7619a68db487e2b18867f52fda --- M src/mainboard/google/sarien/variants/arcada/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/32335/1
diff --git a/src/mainboard/google/sarien/variants/arcada/devicetree.cb b/src/mainboard/google/sarien/variants/arcada/devicetree.cb index 9ecbf00..2056dd6 100644 --- a/src/mainboard/google/sarien/variants/arcada/devicetree.cb +++ b/src/mainboard/google/sarien/variants/arcada/devicetree.cb @@ -28,6 +28,7 @@ register "PchPmSlpAMinAssert" = "4" # 2s
register "speed_shift_enable" = "1" + register "psys_pmax" = "140" register "s0ix_enable" = "1" register "dptf_enable" = "1" register "dmipwroptimize" = "1"
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32335
to look at the new patch set (#2).
Change subject: mb/google/arcada: Set psys_pmax to 140W ......................................................................
mb/google/arcada: Set psys_pmax to 140W
arcada is designed to operate at max power of 140 Watt. Hence set psys_max to 140W.
BUG=b:124792558 BRANCH=None TEST=Build and boot arcada.
Signed-off-by: nathan chen nathan_chen@wistron.corp-partner.google.com
Change-Id: I280dfb81b3e25c7619a68db487e2b18867f52fda --- M src/mainboard/google/sarien/variants/arcada/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/32335/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32335 )
Change subject: mb/google/arcada: Set psys_pmax to 140W ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/32335/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32335/2//COMMIT_MSG@9 PS2, Line 9: arcada is designed to operate at max power of : 140 Watt. Hence set psys_max to 140W. Please use the full text width.
https://review.coreboot.org/#/c/32335/2//COMMIT_MSG@18 PS2, Line 18: Change-Id: I280dfb81b3e25c7619a68db487e2b18867f52fda Please move this right above the Signed-off-by line.
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32335 )
Change subject: mb/google/arcada: Set psys_pmax to 140W ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32335/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32335/2//COMMIT_MSG@13 PS2, Line 13: BRANCH=None Please remove the BRANCH line here, it is not required for coreboot changes
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32335 )
Change subject: mb/google/arcada: Set psys_pmax to 140W ......................................................................
Patch Set 2: Code-Review+1
Hello Patrick Rudolph, Duncan Laurie, Lijian Zhao, build bot (Jenkins), Patrick Georgi, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32335
to look at the new patch set (#3).
Change subject: mb/google/arcada: Set psys_pmax to 140W ......................................................................
mb/google/arcada: Set psys_pmax to 140W
arcada is designed to operate at max power of 140 Watt. Hence set psys_max to 140W.
BUG=b:124792558 TEST=Build and boot arcada.
Change-Id: I280dfb81b3e25c7619a68db487e2b18867f52fda Signed-off-by: nathan chen nathan_chen@wistron.corp-partner.google.com --- M src/mainboard/google/sarien/variants/arcada/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/32335/3
Nathan Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32335 )
Change subject: mb/google/arcada: Set psys_pmax to 140W ......................................................................
Patch Set 3:
(3 comments)
Updated
https://review.coreboot.org/#/c/32335/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32335/2//COMMIT_MSG@9 PS2, Line 9: arcada is designed to operate at max power of : 140 Watt. Hence set psys_max to 140W.
Please use the full text width.
Done
https://review.coreboot.org/#/c/32335/2//COMMIT_MSG@13 PS2, Line 13: BRANCH=None
Please remove the BRANCH line here, it is not required for coreboot changes
Done
https://review.coreboot.org/#/c/32335/2//COMMIT_MSG@18 PS2, Line 18: Change-Id: I280dfb81b3e25c7619a68db487e2b18867f52fda
Please move this right above the Signed-off-by line.
Done
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32335 )
Change subject: mb/google/arcada: Set psys_pmax to 140W ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/32335/3/src/mainboard/google/sarien/variants... File src/mainboard/google/sarien/variants/arcada/devicetree.cb:
https://review.coreboot.org/#/c/32335/3/src/mainboard/google/sarien/variants... PS3, Line 31: 140 How did you arrive to this number ? any document reference ?
Nathan Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32335 )
Change subject: mb/google/arcada: Set psys_pmax to 140W ......................................................................
Patch Set 3:
(1 comment)
Update Power team's comment. Please help to check.
https://review.coreboot.org/#/c/32335/3/src/mainboard/google/sarien/variants... File src/mainboard/google/sarien/variants/arcada/devicetree.cb:
https://review.coreboot.org/#/c/32335/3/src/mainboard/google/sarien/variants... PS3, Line 31: 140
How did you arrive to this number ? any document reference ?
According to Power team's reply. By HW setting –Rpsys=11.5k By Charger Ipsys=0.7465(uA/W) Psys Pmax=1.2/(0.7465u*11.5k)=140w
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32335 )
Change subject: mb/google/arcada: Set psys_pmax to 140W ......................................................................
Patch Set 4: Code-Review+2
Duncan Laurie has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32335 )
Change subject: mb/google/arcada: Set psys_pmax to 140W ......................................................................
mb/google/arcada: Set psys_pmax to 140W
arcada is designed to operate at max power of 140 Watt. Hence set psys_max to 140W.
BUG=b:124792558 TEST=Build and boot arcada.
Change-Id: I280dfb81b3e25c7619a68db487e2b18867f52fda Signed-off-by: nathan chen nathan_chen@wistron.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32335 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Lijian Zhao lijian.zhao@intel.com --- M src/mainboard/google/sarien/variants/arcada/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Lijian Zhao: Looks good to me, approved
diff --git a/src/mainboard/google/sarien/variants/arcada/devicetree.cb b/src/mainboard/google/sarien/variants/arcada/devicetree.cb index 9ecbf00..2056dd6 100644 --- a/src/mainboard/google/sarien/variants/arcada/devicetree.cb +++ b/src/mainboard/google/sarien/variants/arcada/devicetree.cb @@ -28,6 +28,7 @@ register "PchPmSlpAMinAssert" = "4" # 2s
register "speed_shift_enable" = "1" + register "psys_pmax" = "140" register "s0ix_enable" = "1" register "dptf_enable" = "1" register "dmipwroptimize" = "1"