Attention is currently required from: Subrata Banik, Tim Wawrzynczak.
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64089 )
Change subject: intelblocks: Add function to enable GPE
......................................................................
Patch Set 1:
(3 comments)
Patchset:
PS1:
Thanks Maulik for fixing this in proper.
Thank you Subrata :)
File src/soc/intel/common/block/gpio/gpio.c:
https://review.coreboot.org/c/coreboot/+/64089/comment/206e9674_b8fd8722
PS1, Line 173:
tabs ?
Ack. Done
https://review.coreboot.org/c/coreboot/+/64089/comment/de9db84d_8c65e486
PS1, Line 193: if(
if (
Ack. Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64089
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I27e525f50c374c2cc9675e77eaa7774683a6e7c2
Gerrit-Change-Number: 64089
Gerrit-PatchSet: 1
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Fri, 06 May 2022 07:07:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment