Attention is currently required from: Nicholas Sudsgaard.
Angel Pons has posted comments on this change by Nicholas Sudsgaard. ( https://review.coreboot.org/c/coreboot/+/80411?usp=email )
Change subject: Documentation/mainboard/lenovo: Add ThinkCentre M710s ......................................................................
Patch Set 20: Code-Review+1
(5 comments)
File Documentation/mainboard/lenovo/thinkcentre_m710s.md:
https://review.coreboot.org/c/coreboot/+/80411/comment/a9cb37b7_635c24d5?usp... : PS17, Line 200: * DRM issue when using EDK 2 and libgfxinit
Unfortunately I don't remember what error message I was receiving in `dmesg` (I know... […]
Ah, DRM as in https://en.wikipedia.org/wiki/Direct_Rendering_Manager and not https://en.wikipedia.org/wiki/Digital_rights_management
In any case, I see you've dropped the section so I'll resolve this.
File Documentation/mainboard/lenovo/thinkcentre_m710s.md:
https://review.coreboot.org/c/coreboot/+/80411/comment/ceb70ccf_6d146132?usp... : PS20, Line 7: ```eval_rst As per CB:83117
```suggestion ```{eval-rst} ```
https://review.coreboot.org/c/coreboot/+/80411/comment/f7ab4bd3_50fe0a71?usp... : PS20, Line 28: Programming nit: Flashing
https://review.coreboot.org/c/coreboot/+/80411/comment/0c4cb070_5d7feee6?usp... : PS20, Line 30: using the nit
```suggestion The flash chip cannot be flashed internally when running vendor firmware, and must ```
https://review.coreboot.org/c/coreboot/+/80411/comment/51ea1414_6aa75b9f?usp... : PS20, Line 47: Tianocore's EDK 2 Does "Tianocore" mean https://github.com/tianocore/edk2 ?