Attention is currently required from: Karthik Ramasubramanian, Martin L Roth, Raul Rangel.
Jon Murphy has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/coreboot/+/86148?usp=email )
Change subject: util/crossgcc: Add missing printf variable
......................................................................
Patch Set 2:
(2 comments)
File util/crossgcc/buildgcc:
https://review.coreboot.org/c/coreboot/+/86148/comment/9585977f_f8863f06?usp... :
PS1, Line 859: ${LIBSTDCXX_INCLUDE_PATH}
Quote this too, or change it to `[[ ]]`
Done
https://review.coreboot.org/c/coreboot/+/86148/comment/e434975d_eee64eb6?usp... :
PS1, Line 861: ${LIBSTDCXX_INCLUDE_PATH}
Quotes
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86148?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I195718e43ea842970f5fa986315c9e9f11395362
Gerrit-Change-Number: 86148
Gerrit-PatchSet: 2
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 24 Jan 2025 22:27:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org