Attention is currently required from: Paul Menzel, Angel Pons, Jonathon Hall, Felix Held.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74903 )
Change subject: drivers/pc80/rtc/mc146818rtc.c: Add Kconfig for RTC CMOS base addresses
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74903/comment/1ce4f1d0_f6de307e
PS2, Line 17: and the EC BRAM bank 1.
To me, this paragraph seems a bit unnecessary. Details are in the follow-up that actually configures said hardware differently.
File src/drivers/pc80/rtc/Kconfig:
https://review.coreboot.org/c/coreboot/+/74903/comment/da9fde95_03645378
PS2, Line 9: depends on DRIVERS_MC146818
Should this be repeated or grouped under 'if' with added entries?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74903
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie44e5f5191c66f44e2df8ea0ff58a860be88bfcf
Gerrit-Change-Number: 74903
Gerrit-PatchSet: 2
Gerrit-Owner: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 02 May 2023 04:53:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment