Attention is currently required from: YH Lin, Furquan Shaikh, Caveh Jalali, Angel Pons, Nick Vaccaro, Mark Hsieh, Zhuohao Lee.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59299 )
Change subject: mb/google/brya/var/gimble: Include SPD for MT53E512M32D1NP-046 WT:B and MT53E1G32D2NP-046 WT:B
......................................................................
Patch Set 4: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59299/comment/10af2e7d_7b69ccdb
PS4, Line 6:
: mb/google/brya/var/gimble: Include SPD for MT53E512M32D1NP-046 WT:B and MT53E1G32D2NP-046 WT:B
:
suggestion:
`mb/google/brya/gimble: Include 2 new SPDs`
https://review.coreboot.org/c/coreboot/+/59299/comment/69fecc9e_2fcce3f0
PS4, Line 9: Add SPD support to gimble for LPDDR4 memory part MT53E512M32D1NP-046 WT:B and MT53E1G32D2NP-046 WT:B.
:
: BUG=b:191574298
: TEST=USE="project_gimble emerge-brya coreboot" and verify it builds without error.
:
72 characters wide
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59299
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id3fc35605675b953bf993a29f35140f7721eedab
Gerrit-Change-Number: 59299
Gerrit-PatchSet: 4
Gerrit-Owner: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Ariel Fang
ariel_fang@wistron.corp-partner.google.com
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-CC: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-CC: Will Tsai
will_tsai@wistron.corp-partner.google.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Mon, 15 Nov 2021 21:01:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment