Change in coreboot[master]: mb/system76/lemp9: update HDA pin config

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Jeremy Soller (Code Review)

20 Jul 2020 20 Jul '20

6:32 p.m.

Jeremy Soller has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43631 )

Change subject: mb/system76/lemp9: update HDA pin config ......................................................................

mb/system76/lemp9: update HDA pin config

To minimize the quirks the kernel has to apply, the headset mic is set to its correct value in coreboot.

Tested on lemp9, audio is functional

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I6b59de95f01360a5f7779f87f39edeb75dedc215 --- M src/mainboard/system76/lemp9/hda_verb.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/43631/1

diff --git a/src/mainboard/system76/lemp9/hda_verb.c b/src/mainboard/system76/lemp9/hda_verb.c index 3f77dc2..7bb0736 100644 --- a/src/mainboard/system76/lemp9/hda_verb.c +++ b/src/mainboard/system76/lemp9/hda_verb.c @@ -15,7 +15,7 @@ AZALIA_PIN_CFG(0, 0x16, 0x411111f0), AZALIA_PIN_CFG(0, 0x18, 0x411111f0), AZALIA_PIN_CFG(0, 0x19, 0x411111f0), - AZALIA_PIN_CFG(0, 0x1a, 0x411111f0), + AZALIA_PIN_CFG(0, 0x1a, 0x01a1913c), AZALIA_PIN_CFG(0, 0x1b, 0x411111f0), AZALIA_PIN_CFG(0, 0x1d, 0x41748245), AZALIA_PIN_CFG(0, 0x1e, 0x411111f0),

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

Jeremy Soller (Code Review)

20 Jul 20 Jul

7:02 p.m.

Jeremy Soller has uploaded a new patch set (#7). ( https://review.coreboot.org/c/coreboot/+/43631 )

Change subject: mb/system76/lemp9: update HDA pin config ......................................................................

mb/system76/lemp9: update HDA pin config

To minimize the quirks the kernel has to apply, the headset mic is set to its correct value in coreboot.

Tested on lemp9, audio is functional

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I6b59de95f01360a5f7779f87f39edeb75dedc215 --- M src/mainboard/system76/lemp9/hda_verb.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/43631/7

Angel Pons (Code Review)

7:04 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43631 )

Change subject: mb/system76/lemp9: update HDA pin config ......................................................................

Patch Set 7: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/43631/7//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43631/7//COMMIT_MSG@12 PS7, Line 12: Tested on lemp9, audio is functional Please add a period at the end of the sentence.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43631 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6b59de95f01360a5f7779f87f39edeb75dedc215 Gerrit-Change-Number: 43631 Gerrit-PatchSet: 7 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 20 Jul 2020 22:04:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Jeremy Soller (Code Review)

7:11 p.m.

Hello Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43631

to look at the new patch set (#8).

Change subject: mb/system76/lemp9: update HDA pin config ......................................................................

mb/system76/lemp9: update HDA pin config

To minimize the quirks the kernel has to apply, the headset mic is set to its correct value in coreboot.

Tested on lemp9, audio is functional.

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I6b59de95f01360a5f7779f87f39edeb75dedc215 --- M src/mainboard/system76/lemp9/hda_verb.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/43631/8

-- To view, visit https://review.coreboot.org/c/coreboot/+/43631 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6b59de95f01360a5f7779f87f39edeb75dedc215 Gerrit-Change-Number: 43631 Gerrit-PatchSet: 8 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Michael Niewöhner (Code Review)

7:22 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43631 )

Change subject: mb/system76/lemp9: update HDA pin config ......................................................................

Patch Set 8:

Can you give a little more info where the old / new value came from?

-- To view, visit https://review.coreboot.org/c/coreboot/+/43631 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6b59de95f01360a5f7779f87f39edeb75dedc215 Gerrit-Change-Number: 43631 Gerrit-PatchSet: 8 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner Gerrit-Comment-Date: Mon, 20 Jul 2020 22:22:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

7:42 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43631 )

Change subject: mb/system76/lemp9: update HDA pin config ......................................................................

Patch Set 9:

...

Patch Set 8:

Can you give a little more info where the old / new value came from?

The old value means "Disabled", the new value means something. There are macros to make HDA configs human-readable, but why would anyone bother using them? 😭

Look at this hda_verb.c! It's READABLE! 😮 https://review.coreboot.org/c/coreboot/+/39995/4/src/mainboard/siemens/chili...

-- To view, visit https://review.coreboot.org/c/coreboot/+/43631 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6b59de95f01360a5f7779f87f39edeb75dedc215 Gerrit-Change-Number: 43631 Gerrit-PatchSet: 9 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner Gerrit-Comment-Date: Mon, 20 Jul 2020 22:42:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Jeremy Soller (Code Review)

21 Jul 21 Jul

11:20 a.m.

Hello build bot (Jenkins), Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43631

to look at the new patch set (#12).

Change subject: mb/system76/lemp9: update HDA pin config ......................................................................

mb/system76/lemp9: update HDA pin config

To minimize the quirks the kernel has to apply, the headset mic is set to its correct value in coreboot.

Tested on lemp9, audio is functional.

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I6b59de95f01360a5f7779f87f39edeb75dedc215 --- M src/mainboard/system76/lemp9/hda_verb.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/43631/12

-- To view, visit https://review.coreboot.org/c/coreboot/+/43631 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6b59de95f01360a5f7779f87f39edeb75dedc215 Gerrit-Change-Number: 43631 Gerrit-PatchSet: 12 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Jeremy Soller (Code Review)

22 Jul 22 Jul

9:45 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43631

to look at the new patch set (#16).

Change subject: mb/system76/lemp9: update HDA pin config ......................................................................

mb/system76/lemp9: update HDA pin config

To minimize the quirks the kernel has to apply, the headset mic is set to its correct value in coreboot.

Tested on lemp9, audio is functional.

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I6b59de95f01360a5f7779f87f39edeb75dedc215 --- M src/mainboard/system76/lemp9/hda_verb.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/43631/16

-- To view, visit https://review.coreboot.org/c/coreboot/+/43631 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6b59de95f01360a5f7779f87f39edeb75dedc215 Gerrit-Change-Number: 43631 Gerrit-PatchSet: 16 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Jeremy Soller (Code Review)

11:09 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43631

to look at the new patch set (#18).

Change subject: mb/system76/lemp9: update HDA pin config ......................................................................

mb/system76/lemp9: update HDA pin config

To minimize the quirks the kernel has to apply, the headset mic is set to its correct value in coreboot.

Tested on lemp9, audio is functional.

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I6b59de95f01360a5f7779f87f39edeb75dedc215 --- M src/mainboard/system76/lemp9/hda_verb.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/43631/18

-- To view, visit https://review.coreboot.org/c/coreboot/+/43631 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6b59de95f01360a5f7779f87f39edeb75dedc215 Gerrit-Change-Number: 43631 Gerrit-PatchSet: 18 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Michael Niewöhner (Code Review)

6:03 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43631 )

Change subject: mb/system76/lemp9: update HDA pin config ......................................................................

Patch Set 18: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/43631 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6b59de95f01360a5f7779f87f39edeb75dedc215 Gerrit-Change-Number: 43631 Gerrit-PatchSet: 18 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 22 Jul 2020 21:03:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

30 Aug 30 Aug

10:17 a.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43631 )

Change subject: mb/system76/lemp9: update HDA pin config ......................................................................

Patch Set 19: Code-Review+2

tested; works fine for me, too

-- To view, visit https://review.coreboot.org/c/coreboot/+/43631 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6b59de95f01360a5f7779f87f39edeb75dedc215 Gerrit-Change-Number: 43631 Gerrit-PatchSet: 19 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 30 Aug 2020 13:17:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

6 Sep 6 Sep

12:15 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43631 )

Change subject: mb/system76/lemp9: update HDA pin config ......................................................................

Patch Set 19:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43631/7//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43631/7//COMMIT_MSG@12 PS7, Line 12: Tested on lemp9, audio is functional

...

Please add a period at the end of the sentence.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/43631 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6b59de95f01360a5f7779f87f39edeb75dedc215 Gerrit-Change-Number: 43631 Gerrit-PatchSet: 19 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 06 Sep 2020 15:15:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Patrick Georgi (Code Review)

8 Sep 8 Sep

2:35 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43631 )

Change subject: mb/system76/lemp9: update HDA pin config ......................................................................

mb/system76/lemp9: update HDA pin config

To minimize the quirks the kernel has to apply, the headset mic is set to its correct value in coreboot.

Tested on lemp9, audio is functional.

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I6b59de95f01360a5f7779f87f39edeb75dedc215 Reviewed-on: https://review.coreboot.org/c/coreboot/+/43631 Reviewed-by: Michael Niewöhner Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/system76/lemp9/hda_verb.c 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/coreboot/+/43631 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6b59de95f01360a5f7779f87f39edeb75dedc215 Gerrit-Change-Number: 43631 Gerrit-PatchSet: 20 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1685

days inactive

1735

days old

coreboot-gerrit@coreboot.org

12 comments

4 participants

tags (0)

participants (4)

Angel Pons (Code Review)
Jeremy Soller (Code Review)
Michael Niewöhner (Code Review)
Patrick Georgi (Code Review)