build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/15164 )
Change subject: nb/amd/pi/00730F01: Add initial native IVRS support ......................................................................
Patch Set 23:
(9 comments)
https://review.coreboot.org/#/c/15164/23/src/northbridge/amd/pi/00730F01/nor... File src/northbridge/amd/pi/00730F01/northbridge.c:
https://review.coreboot.org/#/c/15164/23/src/northbridge/amd/pi/00730F01/nor... PS23, Line 488: unsigned int depth, int linknum, int8_t *root_level, line over 80 characters
https://review.coreboot.org/#/c/15164/23/src/northbridge/amd/pi/00730F01/nor... PS23, Line 511: add_ivhd_dev_entry(parent, dev, current, length, 0x2, 0x97); line over 80 characters
https://review.coreboot.org/#/c/15164/23/src/northbridge/amd/pi/00730F01/nor... PS23, Line 517: add_ivhd_dev_entry(parent, dev, current, length, 0x2, 0x0); line over 80 characters
https://review.coreboot.org/#/c/15164/23/src/northbridge/amd/pi/00730F01/nor... PS23, Line 521: is_pcie = pci_find_capability(dev, PCI_CAP_ID_PCIE); line over 80 characters
https://review.coreboot.org/#/c/15164/23/src/northbridge/amd/pi/00730F01/nor... PS23, Line 526: add_ivhd_dev_entry(parent, dev, current, length, 0x2, 0x0); line over 80 characters
https://review.coreboot.org/#/c/15164/23/src/northbridge/amd/pi/00730F01/nor... PS23, Line 527: } else if ((header_type == PCI_HEADER_TYPE_NORMAL) && line over 80 characters
https://review.coreboot.org/#/c/15164/23/src/northbridge/amd/pi/00730F01/nor... PS23, Line 529: add_ivhd_dev_entry(parent, dev, current, length, 0x42, 0x0); line over 80 characters
https://review.coreboot.org/#/c/15164/23/src/northbridge/amd/pi/00730F01/nor... PS23, Line 589: printk(BIOS_WARNING, "%s: G-series northbridge device not present!\n", __func__); line over 80 characters
https://review.coreboot.org/#/c/15164/23/src/northbridge/amd/pi/00730F01/nor... PS23, Line 590: printk(BIOS_WARNING, "%s: IVRS table not generated...\n", __func__); line over 80 characters
-
build bot (Jenkins) (Code Review)