Angel Pons has posted comments on this change. ( https://review.coreboot.org/28258 )
Change subject: mb/intel/dg43gt: Add documentation ......................................................................
Patch Set 2:
(8 comments)
https://review.coreboot.org/#/c/28258/2/Documentation/mainboard/intel/dg43gt... File Documentation/mainboard/intel/dg43gt.md:
https://review.coreboot.org/#/c/28258/2/Documentation/mainboard/intel/dg43gt... PS2, Line 17: NO! Any reason for this to be so intense? In any case, please harmonize the "yes" and "no" in the table (Yes/yes).
https://review.coreboot.org/#/c/28258/2/Documentation/mainboard/intel/dg43gt... PS2, Line 32: to written to *be* written
https://review.coreboot.org/#/c/28258/2/Documentation/mainboard/intel/dg43gt... PS2, Line 34: --noverify Is there any reason for this? If it is not necessary, I would omit it.
https://review.coreboot.org/#/c/28258/2/Documentation/mainboard/intel/dg43gt... PS2, Line 45: reprogram
maybe "reprogram it"?
With the sentence as-is, I understand you can both reprogram and resolder the chip using a soldering iron.
IMHO, I would say: "Having removed the flash chip, you can reprogram it externally then resolder it using a soldering iron.".
https://review.coreboot.org/#/c/28258/2/Documentation/mainboard/intel/dg43gt... PS2, Line 51: this *T*his
https://review.coreboot.org/#/c/28258/2/Documentation/mainboard/intel/dg43gt... PS2, Line 53: 3V 3.3V, maybe?
https://review.coreboot.org/#/c/28258/2/Documentation/mainboard/intel/dg43gt... PS2, Line 88: Windond Win*b*ond
Should the model be in uppercase? (W83627DHG)
https://review.coreboot.org/#/c/28258/2/Documentation/mainboard/intel/dg43gt... PS2, Line 90: optionnaly optionally
-
Angel Pons (Code Review)