Change in coreboot[master]: mb/**/acpi_tables.c: Drop lid settings on desktops

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Angel Pons (Code Review)

30 Dec 2019 30 Dec '19

12:47 a.m.

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37993 )

Change subject: mb/**/acpi_tables.c: Drop lid settings on desktops ......................................................................

mb/**/acpi_tables.c: Drop lid settings on desktops

Unike laptops and some trash cans, desktop boardss do not have a lid.

Change-Id: I5f947e411a4c9295a294f55771cd123de6b1e702 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/asrock/b75pro3-m/acpi_tables.c M src/mainboard/intel/dcp847ske/acpi_tables.c M src/mainboard/sapphire/pureplatinumh61/acpi_tables.c 3 files changed, 0 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/37993/1

diff --git a/src/mainboard/asrock/b75pro3-m/acpi_tables.c b/src/mainboard/asrock/b75pro3-m/acpi_tables.c index 7d634a0..370b709 100644 --- a/src/mainboard/asrock/b75pro3-m/acpi_tables.c +++ b/src/mainboard/asrock/b75pro3-m/acpi_tables.c @@ -27,9 +27,6 @@ gnvs->s5u0 = 0; gnvs->s5u1 = 0;

- // the lid is open by default. - gnvs->lids = 1; - gnvs->tcrt = 100; gnvs->tpsv = 90; } diff --git a/src/mainboard/intel/dcp847ske/acpi_tables.c b/src/mainboard/intel/dcp847ske/acpi_tables.c index 88c7019..0d9c2c5 100644 --- a/src/mainboard/intel/dcp847ske/acpi_tables.c +++ b/src/mainboard/intel/dcp847ske/acpi_tables.c @@ -28,9 +28,6 @@ gnvs->s5u0 = 1; gnvs->s5u1 = 1;

- // No LID: open by default. - gnvs->lids = 1; - gnvs->tcrt = CRITICAL_TEMPERATURE; gnvs->tpsv = PASSIVE_TEMPERATURE; } diff --git a/src/mainboard/sapphire/pureplatinumh61/acpi_tables.c b/src/mainboard/sapphire/pureplatinumh61/acpi_tables.c index a790b0b..8503ccd 100644 --- a/src/mainboard/sapphire/pureplatinumh61/acpi_tables.c +++ b/src/mainboard/sapphire/pureplatinumh61/acpi_tables.c @@ -26,9 +26,6 @@ gnvs->s5u0 = 0; gnvs->s5u1 = 0;

- // the lid is open by default. - gnvs->lids = 1; - gnvs->tcrt = 100; gnvs->tpsv = 90; }

Attachments:

attachment.htm (text/html — 4.0 KB)

Show replies by date

Angel Pons (Code Review)

31 Dec 31 Dec

10:22 p.m.

Hello Matt DeVillier, build bot (Jenkins), Nico Huber, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37993

to look at the new patch set (#2).

Change subject: mb/**/acpi_tables.c: Drop lid settings on desktops ......................................................................

mb/**/acpi_tables.c: Drop lid settings on desktops

Unike laptops and some trash cans, desktop boards do not have a lid.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/37993/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/37993 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f947e411a4c9295a294f55771cd123de6b1e702 Gerrit-Change-Number: 37993 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Nico Huber (Code Review)

1 Jan 1 Jan

3:08 a.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37993 )

Change subject: mb/**/acpi_tables.c: Drop lid settings on desktops ......................................................................

Patch Set 2: Code-Review+2

(1 comment)

needs rebase

https://review.coreboot.org/c/coreboot/+/37993/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/37993/2//COMMIT_MSG@9 PS2, Line 9: Unike Unlike

Angel Pons (Code Review)

4:30 a.m.

Hello Matt DeVillier, build bot (Jenkins), Nico Huber, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37993

to look at the new patch set (#3).

Change subject: mb/**/acpi_tables.c: Drop lid settings on desktops ......................................................................

mb/**/acpi_tables.c: Drop lid settings on desktops

Unlike laptops and some trash cans, desktop boards do not have a lid.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/37993/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/37993 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f947e411a4c9295a294f55771cd123de6b1e702 Gerrit-Change-Number: 37993 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Angel Pons (Code Review)

4:30 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37993 )

Change subject: mb/**/acpi_tables.c: Drop lid settings on desktops ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37993/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/37993/2//COMMIT_MSG@9 PS2, Line 9: Unike

...

Unlike

Oops, done

-- To view, visit https://review.coreboot.org/c/coreboot/+/37993 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f947e411a4c9295a294f55771cd123de6b1e702 Gerrit-Change-Number: 37993 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 01 Jan 2020 03:30:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

Angel Pons (Code Review)

4:32 a.m.

Hello Matt DeVillier, build bot (Jenkins), Nico Huber, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37993

to look at the new patch set (#4).

Change subject: mb/**/acpi_tables.c: Drop lid settings on desktops ......................................................................

mb/**/acpi_tables.c: Drop lid settings on desktops

Unlike laptops and some trash cans, desktop boards do not have a lid.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/37993/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/37993 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f947e411a4c9295a294f55771cd123de6b1e702 Gerrit-Change-Number: 37993 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Angel Pons (Code Review)

4:33 a.m.

Hello Matt DeVillier, build bot (Jenkins), Nico Huber, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37993

to look at the new patch set (#5).

Change subject: mb/**/acpi_tables.c: Drop lid settings on desktops ......................................................................

mb/**/acpi_tables.c: Drop lid settings on desktops

Unlike laptops and some trash cans, desktop boards do not have a lid.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/37993/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/37993 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f947e411a4c9295a294f55771cd123de6b1e702 Gerrit-Change-Number: 37993 Gerrit-PatchSet: 5 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Angel Pons (Code Review)

4:34 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37993 )

Change subject: mb/**/acpi_tables.c: Drop lid settings on desktops ......................................................................

Patch Set 5:

Had to fix some merge conflicts manually, oh well.

-- To view, visit https://review.coreboot.org/c/coreboot/+/37993 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f947e411a4c9295a294f55771cd123de6b1e702 Gerrit-Change-Number: 37993 Gerrit-PatchSet: 5 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 01 Jan 2020 03:34:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Nico Huber (Code Review)

2:59 p.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37993 )

Change subject: mb/**/acpi_tables.c: Drop lid settings on desktops ......................................................................

Patch Set 5: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/37993 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f947e411a4c9295a294f55771cd123de6b1e702 Gerrit-Change-Number: 37993 Gerrit-PatchSet: 5 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 01 Jan 2020 13:59:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

2 Jan 2 Jan

3:36 p.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37993 )

Change subject: mb/**/acpi_tables.c: Drop lid settings on desktops ......................................................................

mb/**/acpi_tables.c: Drop lid settings on desktops

Unlike laptops and some trash cans, desktop boards do not have a lid.

Change-Id: I5f947e411a4c9295a294f55771cd123de6b1e702 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37993 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/mainboard/asrock/b75pro3-m/acpi_tables.c M src/mainboard/intel/dcp847ske/acpi_tables.c M src/mainboard/sapphire/pureplatinumh61/acpi_tables.c 3 files changed, 0 insertions(+), 9 deletions(-)

Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved

diff --git a/src/mainboard/asrock/b75pro3-m/acpi_tables.c b/src/mainboard/asrock/b75pro3-m/acpi_tables.c index 114f6e1..6727616 100644 --- a/src/mainboard/asrock/b75pro3-m/acpi_tables.c +++ b/src/mainboard/asrock/b75pro3-m/acpi_tables.c @@ -19,9 +19,6 @@

void acpi_create_gnvs(global_nvs_t *gnvs) { - // the lid is open by default. - gnvs->lids = 1; - gnvs->tcrt = 100; gnvs->tpsv = 90; } diff --git a/src/mainboard/intel/dcp847ske/acpi_tables.c b/src/mainboard/intel/dcp847ske/acpi_tables.c index 88c7019..0d9c2c5 100644 --- a/src/mainboard/intel/dcp847ske/acpi_tables.c +++ b/src/mainboard/intel/dcp847ske/acpi_tables.c @@ -28,9 +28,6 @@ gnvs->s5u0 = 1; gnvs->s5u1 = 1;

- // No LID: open by default. - gnvs->lids = 1; - gnvs->tcrt = CRITICAL_TEMPERATURE; gnvs->tpsv = PASSIVE_TEMPERATURE; } diff --git a/src/mainboard/sapphire/pureplatinumh61/acpi_tables.c b/src/mainboard/sapphire/pureplatinumh61/acpi_tables.c index 9c08af1..a275843 100644 --- a/src/mainboard/sapphire/pureplatinumh61/acpi_tables.c +++ b/src/mainboard/sapphire/pureplatinumh61/acpi_tables.c @@ -18,9 +18,6 @@

void acpi_create_gnvs(global_nvs_t *gnvs) { - // the lid is open by default. - gnvs->lids = 1; - gnvs->tcrt = 100; gnvs->tpsv = 90; }

-- To view, visit https://review.coreboot.org/c/coreboot/+/37993 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f947e411a4c9295a294f55771cd123de6b1e702 Gerrit-Change-Number: 37993 Gerrit-PatchSet: 6 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1787

days inactive

1791

days old

coreboot-gerrit@coreboot.org

9 comments

3 participants

tags (0)

participants (3)

Angel Pons (Code Review)
Nico Huber (Code Review)
Patrick Georgi (Code Review)