Edward O'Callaghan (eocallaghan@alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6423
-gerrit
commit e71a527de48f3ce7d606111023148d40e4e20207 Author: Edward O'Callaghan eocallaghan@alterapraxis.com Date: Thu Jul 31 17:56:51 2014 +1000
vendorcode/intel/fsp/rangeley/include: Missing 'fsptypes.h'
Without the inclusion of 'fsptypes.h' the order of inclusion becomes tentative.
Change-Id: I6360e4ebac6c414c380a19ef69d39d658ea203bd Signed-off-by: Edward O'Callaghan eocallaghan@alterapraxis.com --- src/vendorcode/intel/fsp/rangeley/include/fspapi.h | 4 +++- src/vendorcode/intel/fsp/rangeley/include/fspffs.h | 3 ++- src/vendorcode/intel/fsp/rangeley/include/fspfv.h | 2 ++ src/vendorcode/intel/fsp/rangeley/include/fsphob.h | 2 ++ 4 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/src/vendorcode/intel/fsp/rangeley/include/fspapi.h b/src/vendorcode/intel/fsp/rangeley/include/fspapi.h index 5378b2a..5009246 100644 --- a/src/vendorcode/intel/fsp/rangeley/include/fspapi.h +++ b/src/vendorcode/intel/fsp/rangeley/include/fspapi.h @@ -31,6 +31,8 @@ are permitted provided that the following conditions are met: #ifndef _FSP_API_H_ #define _FSP_API_H_
+#include <fsptypes.h> + #pragma pack(1)
typedef VOID (* CONTINUATION_PROC)(EFI_STATUS Status, VOID *HobListPtr); @@ -62,4 +64,4 @@ typedef struct { typedef FSP_STATUS (FSPAPI *FSP_FSP_INIT) (FSP_INIT_PARAMS *FspInitParamPtr); typedef FSP_STATUS (FSPAPI *FSP_NOTFY_PHASE) (NOTIFY_PHASE_PARAMS *NotifyPhaseParamPtr);
-#endif \ No newline at end of file +#endif /* _FSP_API_H_ */ diff --git a/src/vendorcode/intel/fsp/rangeley/include/fspffs.h b/src/vendorcode/intel/fsp/rangeley/include/fspffs.h index 7a7c367..9e8244d 100644 --- a/src/vendorcode/intel/fsp/rangeley/include/fspffs.h +++ b/src/vendorcode/intel/fsp/rangeley/include/fspffs.h @@ -28,10 +28,11 @@ are permitted provided that the following conditions are met:
**/
- #ifndef __PI_FIRMWARE_FILE_H__ #define __PI_FIRMWARE_FILE_H__
+#include <fsptypes.h> + #pragma pack(1) /// /// Used to verify the integrity of the file. diff --git a/src/vendorcode/intel/fsp/rangeley/include/fspfv.h b/src/vendorcode/intel/fsp/rangeley/include/fspfv.h index 75d17fa..9688cf4 100644 --- a/src/vendorcode/intel/fsp/rangeley/include/fspfv.h +++ b/src/vendorcode/intel/fsp/rangeley/include/fspfv.h @@ -31,6 +31,8 @@ are permitted provided that the following conditions are met: #ifndef __PI_FIRMWAREVOLUME_H__ #define __PI_FIRMWAREVOLUME_H__
+#include <fsptypes.h> + /// /// EFI_FV_FILE_ATTRIBUTES /// diff --git a/src/vendorcode/intel/fsp/rangeley/include/fsphob.h b/src/vendorcode/intel/fsp/rangeley/include/fsphob.h index a9c0bce..0f743b5 100644 --- a/src/vendorcode/intel/fsp/rangeley/include/fsphob.h +++ b/src/vendorcode/intel/fsp/rangeley/include/fsphob.h @@ -31,6 +31,8 @@ are permitted provided that the following conditions are met: #ifndef __PI_HOB_H__ #define __PI_HOB_H__
+#include <fsptypes.h> + // // HobType of EFI_HOB_GENERIC_HEADER. //