Attention is currently required from: Paul Menzel, Patrick Rudolph.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62008 )
Change subject: drivers/intel/i210: Set log level to BIOS_NOTICE on missing MAC address
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62008/comment/f243d6bc_b418f31e
PS1, Line 12:
I still think the second case is an error, as the user would expect the MAC address to be used from […]
I have rephrased the message a bit to make clear that the MAC address stored in the MAC will be uesed if the mainboard does not provide an address.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62008
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibfc58845f0ea47ced048b446e685c4860a29f075
Gerrit-Change-Number: 62008
Gerrit-PatchSet: 2
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 07 Mar 2022 05:56:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment