Attention is currently required from: Boris Mittelberg, Brandon Breitenstein, Caveh Jalali, Hannah Williams, Kapil Porwal, Subrata Banik, Sukumar Ghorai, Tim Van Patten.
Jamie Ryu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78321?usp=email )
Change subject: ec/google/chromeec: Add is_battery_level_enough to check battery status
......................................................................
Patch Set 5:
(2 comments)
File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/78321/comment/3ebe8fe2_46fc3fb3 :
PS4, Line 1538: dynamic_p
I used the same variable names from ec/util/ectool. […]
this is updated to patchset#5.
https://review.coreboot.org/c/coreboot/+/78321/comment/163184dd_98f06e96 :
PS4, Line 1543: if (ec_cmd_battery_get_dynamic(PLAT_EC, &dynamic_p, &dynamic_r) != 0)
We only care if the Battery is cutoff right? If the battery is in low battery state it would still […]
the patchset#5 is updated to check 'no battery/battery cutoff' and 'batt_ level_critical' to return if the battery level and battery status are good enough.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78321?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib38be55bc42559bab4f12d5e8580ddc3e1a6acc1
Gerrit-Change-Number: 78321
Gerrit-PatchSet: 5
Gerrit-Owner: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Tim Van Patten
timvp@google.com
Gerrit-Attention: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Attention: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Fri, 13 Oct 2023 22:35:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jamie Ryu
jamie.m.ryu@intel.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Comment-In-Reply-To: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-MessageType: comment