Change in ...coreboot[master]: src/superio/nuvoton/common/early_serial.c: Add symbol to select COM p...

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Pavel Sayekat (Code Review)

27 Jun 2019 27 Jun '19

2:41 p.m.

Pavel Sayekat has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33841

Change subject: src/superio/nuvoton/common/early_serial.c: Add symbol to select COM port for NCT5539D src/superio/nuvoton/Makefile.inc: Add definition for NCT5539D src/superio/nuvoton: Add support for NCT5539D ......................................................................

src/superio/nuvoton/common/early_serial.c: Add symbol to select COM port for NCT5539D src/superio/nuvoton/Makefile.inc: Add definition for NCT5539D src/superio/nuvoton: Add support for NCT5539D

Signed-off-by: Pavel Sayekat pavelsayekat@gmail.com Change-Id: I3c07eb97f879033ff500c632f6cb42e5e7a61024 --- M src/superio/nuvoton/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/33841/1

diff --git a/src/superio/nuvoton/Makefile.inc b/src/superio/nuvoton/Makefile.inc index de4e99c..7306242 100644 --- a/src/superio/nuvoton/Makefile.inc +++ b/src/superio/nuvoton/Makefile.inc @@ -24,3 +24,4 @@ subdirs-$(CONFIG_SUPERIO_NUVOTON_NCT6779D) += nct6779d subdirs-$(CONFIG_SUPERIO_NUVOTON_NCT6791D) += nct6791d subdirs-$(CONFIG_SUPERIO_NUVOTON_NPCD378) += npcd378 +subdirs-$(CONFIG_SUPERIO_NUVOTON_NCT5539D) += nct5539d

Attachments:

attachment.htm (text/html — 2.4 KB)

Show replies by date

Pavel Sayekat (Code Review)

27 Jun 27 Jun

2:45 p.m.

Pavel Sayekat has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/33841 )

Change subject: src/superio/nuvoton/common/early_serial.c: Add symbol to select COM port for NCT5539D ......................................................................

src/superio/nuvoton/common/early_serial.c: Add symbol to select COM port for NCT5539D

src/superio/nuvoton/Makefile.inc: Add definition for NCT5539D

src/superio/nuvoton: Add support for NCT5539D

Change-Id: I3c07eb97f879033ff500c632f6cb42e5e7a61024 Signed-off-by: Pavel Sayekat pavelsayekat@gmail.com --- M src/superio/nuvoton/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/33841/2

Pavel Sayekat (Code Review)

2:46 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33841

to look at the new patch set (#3).

Change subject: src/superio/nuvoton/common/early_serial.c: Add symbol to select COM port for NCT5539D ......................................................................

src/superio/nuvoton/common/early_serial.c: Add symbol to select COM port for NCT5539D

src/superio/nuvoton/Makefile.inc: Add definition for NCT5539D

src/superio/nuvoton: Add support for NCT5539D

Change-Id: I3c07eb97f879033ff500c632f6cb42e5e7a61024 Signed-off-by: Pavel Sayekat pavelsayekat@gmail.com --- M src/superio/nuvoton/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/33841/3

Paul Menzel (Code Review)

3:16 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33841 )

Change subject: src/superio/nuvoton/common/early_serial.c: Add symbol to select COM port for NCT5539D ......................................................................

Patch Set 3:

Welcome to coreboot! Please look through `git log` how to write commit messages.

-- To view, visit https://review.coreboot.org/c/coreboot/+/33841 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3c07eb97f879033ff500c632f6cb42e5e7a61024 Gerrit-Change-Number: 33841 Gerrit-PatchSet: 3 Gerrit-Owner: Pavel Sayekat Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Pavel Sayekat Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 27 Jun 2019 13:16:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

3:26 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33841 )

Change subject: src/superio/nuvoton/common/early_serial.c: Add symbol to select COM port for NCT5539D ......................................................................

Patch Set 3:

Looks like you pushed the three commit messages, but did not push the changes. Oops.

-- To view, visit https://review.coreboot.org/c/coreboot/+/33841 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3c07eb97f879033ff500c632f6cb42e5e7a61024 Gerrit-Change-Number: 33841 Gerrit-PatchSet: 3 Gerrit-Owner: Pavel Sayekat Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Pavel Sayekat Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 27 Jun 2019 13:26:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Pavel Sayekat (Code Review)

4:06 p.m.

Hello Felix Held, Angel Pons, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33841

to look at the new patch set (#4).

Change subject: src/superio/nuvoton/common/early_serial.c: Add symbol to select COM port for NCT5539D ......................................................................

src/superio/nuvoton/common/early_serial.c: Add symbol to select COM port for NCT5539D

src/superio/nuvoton/Makefile.inc: Add definition for NCT5539D

src/superio/nuvoton: Add support for NCT5539D

Change-Id: I3c07eb97f879033ff500c632f6cb42e5e7a61024 Signed-off-by: Pavel Sayekat pavelsayekat@gmail.com --- M src/superio/nuvoton/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/33841/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/33841 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3c07eb97f879033ff500c632f6cb42e5e7a61024 Gerrit-Change-Number: 33841 Gerrit-PatchSet: 4 Gerrit-Owner: Pavel Sayekat Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Pavel Sayekat Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Felix Held (Code Review)

4:16 p.m.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33841 )

Change subject: src/superio/nuvoton/common/early_serial.c: Add symbol to select COM port for NCT5539D ......................................................................

Patch Set 4:

seems that something went wrong here; the abandoned patch 33840 seems to contain most of the code for that SIO

-- To view, visit https://review.coreboot.org/c/coreboot/+/33841 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3c07eb97f879033ff500c632f6cb42e5e7a61024 Gerrit-Change-Number: 33841 Gerrit-PatchSet: 4 Gerrit-Owner: Pavlushka Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Pavlushka Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 27 Jun 2019 14:16:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Pavlushka (Code Review)

4:49 p.m.

Hello Felix Held, Angel Pons, Felix Singer, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33841

to look at the new patch set (#5).

Change subject: src/superio/nuvoton/common/early_serial.c: Add symbol to select COM port for NCT5539D ......................................................................

src/superio/nuvoton/common/early_serial.c: Add symbol to select COM port for NCT5539D

src/superio/nuvoton/Makefile.inc: Add definition for NCT5539D

src/superio/nuvoton: Add support for NCT5539D

Change-Id: I3c07eb97f879033ff500c632f6cb42e5e7a61024 Signed-off-by: Pavel Sayekat pavelsayekat@gmail.com --- M src/mainboard/up/squared/upsquared.fmd M src/superio/nuvoton/Makefile.inc M src/superio/nuvoton/common/early_serial.c A src/superio/nuvoton/nct5539d/Kconfig A src/superio/nuvoton/nct5539d/Makefile.inc A src/superio/nuvoton/nct5539d/nct5539d.h A src/superio/nuvoton/nct5539d/superio.c 7 files changed, 201 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/33841/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/33841 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3c07eb97f879033ff500c632f6cb42e5e7a61024 Gerrit-Change-Number: 33841 Gerrit-PatchSet: 5 Gerrit-Owner: Pavlushka Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Pavlushka Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Pavlushka (Code Review)

4:52 p.m.

Pavlushka has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33841 )

Change subject: src/superio/nuvoton/common/early_serial.c: Add symbol to select COM port for NCT5539D ......................................................................

Abandoned

total mess

-- To view, visit https://review.coreboot.org/c/coreboot/+/33841 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3c07eb97f879033ff500c632f6cb42e5e7a61024 Gerrit-Change-Number: 33841 Gerrit-PatchSet: 5 Gerrit-Owner: Pavlushka Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Pavlushka Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

1967

days inactive

1967

days old

coreboot-gerrit@coreboot.org

8 comments

5 participants

tags (0)

participants (5)

Angel Pons (Code Review)
Felix Held (Code Review)
Paul Menzel (Code Review)
Pavel Sayekat (Code Review)
Pavlushka (Code Review)