Attention is currently required from: Jakub Czapiga, Tim Wawrzynczak, Ivy Jian.
Hello Frank Wu, build bot (Jenkins), Jakub Czapiga, Subrata Banik, Tim Wawrzynczak, Ivy Jian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/63628
to look at the new patch set (#3).
Change subject: lib: Treat dimm addr_map 0 as not exist
......................................................................
lib: Treat dimm addr_map 0 as not exist
Treat dimm addr_map 0 as not exist. addr_map default is 0, we don't set
it if there no HW exist. Also change the test case default to avoid 0.
SODIMM SMbus address 0x50 to 0x53 is common used.
BUG=b:213964936
BRANCH=firmware-brya-14505.B
TEST=emerge-brya coreboot chromeos-bootimage
The MRC training does not be performed again after rebooting.
Signed-off-by: Eric Lai eric_lai@quanta.corp-partner.google.com
Change-Id: I2ada0109eb0805174cb85d4ce373e2a3ab7dbcac
---
M src/lib/spd_cache.c
M tests/lib/spd_cache-test.c
2 files changed, 9 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/63628/3
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63628
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2ada0109eb0805174cb85d4ce373e2a3ab7dbcac
Gerrit-Change-Number: 63628
Gerrit-PatchSet: 3
Gerrit-Owner: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-CC: John Su
john_su@compal.corp-partner.google.com
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-MessageType: newpatchset