Aaron Durbin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44486 )
Change subject: soc/amd/picasso: remove unused soc_power_reg object ......................................................................
soc/amd/picasso: remove unused soc_power_reg object
Now that no one is consuming this object, remove its definition.
BUG=b:159947207
Signed-off-by: Aaron Durbin adurbin@chromium.org Change-Id: I60e4a9bfdf2752923f46a35aaab7034f9fa9b309 --- M src/soc/amd/picasso/include/soc/southbridge.h 1 file changed, 0 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/44486/1
diff --git a/src/soc/amd/picasso/include/soc/southbridge.h b/src/soc/amd/picasso/include/soc/southbridge.h index e9f7e2e..e4ae8dc 100644 --- a/src/soc/amd/picasso/include/soc/southbridge.h +++ b/src/soc/amd/picasso/include/soc/southbridge.h @@ -268,14 +268,6 @@ unsigned int :4; } __packed aoac_devs_t;
-struct soc_power_reg { - uint16_t pm1_sts; - uint16_t pm1_en; - uint32_t gpe0_sts; - uint32_t gpe0_en; - uint16_t wake_from; -}; - void enable_aoac_devices(void); bool is_aoac_device_enabled(int dev); void power_on_aoac_device(int dev);
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44486 )
Change subject: soc/amd/picasso: remove unused soc_power_reg object ......................................................................
Patch Set 1: Code-Review+2
Aaron Durbin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44486 )
Change subject: soc/amd/picasso: remove unused soc_power_reg object ......................................................................
soc/amd/picasso: remove unused soc_power_reg object
Now that no one is consuming this object, remove its definition.
BUG=b:159947207
Signed-off-by: Aaron Durbin adurbin@chromium.org Change-Id: I60e4a9bfdf2752923f46a35aaab7034f9fa9b309 Reviewed-on: https://review.coreboot.org/c/coreboot/+/44486 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/soc/amd/picasso/include/soc/southbridge.h 1 file changed, 0 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/soc/amd/picasso/include/soc/southbridge.h b/src/soc/amd/picasso/include/soc/southbridge.h index e9f7e2e..e4ae8dc 100644 --- a/src/soc/amd/picasso/include/soc/southbridge.h +++ b/src/soc/amd/picasso/include/soc/southbridge.h @@ -268,14 +268,6 @@ unsigned int :4; } __packed aoac_devs_t;
-struct soc_power_reg { - uint16_t pm1_sts; - uint16_t pm1_en; - uint32_t gpe0_sts; - uint32_t gpe0_en; - uint16_t wake_from; -}; - void enable_aoac_devices(void); bool is_aoac_device_enabled(int dev); void power_on_aoac_device(int dev);
-
Aaron Durbin (Code Review) -
Furquan Shaikh (Code Review)