Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32255
Change subject: mb/google/ampton: Fix polarity of EN_PP3300_WLAN_L signal. ......................................................................
mb/google/ampton: Fix polarity of EN_PP3300_WLAN_L signal.
WiFi enable signal Was configured and driven as active-high, but the signal is actually active-low.
BUG=b:130196983 BRANCH=none TEST=Verified WiFi still works after boot, and also after a suspend/resume cycle. Device powers down correctly using "poweroff".
Change-Id: I64a67f73564188ad0548a1a770169ef2bca47453 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/octopus/variants/ampton/gpio.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/32255/1
diff --git a/src/mainboard/google/octopus/variants/ampton/gpio.c b/src/mainboard/google/octopus/variants/ampton/gpio.c index 984dae0..0eac121 100644 --- a/src/mainboard/google/octopus/variants/ampton/gpio.c +++ b/src/mainboard/google/octopus/variants/ampton/gpio.c @@ -246,7 +246,7 @@ /* SCC COMMUNITY GPIOS */ PAD_NC(GPIO_176, UP_20K), /* SMB_ALERTB -- unused */ PAD_NC(GPIO_177, UP_20K), /* SMB_CLK -- unused */ - PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 1, DEEP, NONE, Tx1RxDCRx0, DISPUPD), /* EN_PP3300_WLAN */ + PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 1, DEEP, NONE, Tx0RxDCRx0, DISPUPD), /* EN_PP3300_WLAN */ PAD_NC(GPIO_179, NONE), /* SDCARD_CLK -- unused */ PAD_NC(GPIO_180, NONE), /* SDCARD_CMD -- unused */ PAD_NC(GPIO_181, UP_20K), /* SDCARD_D0 -- unused */ @@ -305,11 +305,11 @@ PAD_CFG_NF(GPIO_83, NONE, DEEP, NF1), /* H1_SLAVE_SPI_MOSI_R */
/* Enable power to wifi early in bootblock and de-assert PERST#. */ - PAD_CFG_GPO(GPIO_178, 1, DEEP), /* EN_PP3300_WLAN */ + PAD_CFG_GPO(GPIO_178, 0, DEEP), /* EN_PP3300_WLAN */ PAD_CFG_GPO(GPIO_164, 0, DEEP), /* WLAN_PE_RST */
/* - * ESPI_IO1 acts as ALERT# (which is open-drain) and requies a weak + * ESPI_IO1 acts as ALERT# (which is open-drain) and requires a weak * pull-up for proper operation. Since there is no external pull present * on this platform, configure an internal weak pull-up. */
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32255 )
Change subject: mb/google/ampton: Fix polarity of EN_PP3300_WLAN_L signal. ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32255/1/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/ampton/gpio.c:
https://review.coreboot.org/#/c/32255/1/src/mainboard/google/octopus/variant... PS1, Line 249: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 1, DEEP, NONE, Tx0RxDCRx0, DISPUPD), /* EN_PP3300_WLAN */ line over 80 characters
Hello Justin TerAvest, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32255
to look at the new patch set (#2).
Change subject: mb/google/ampton: Fix polarity of EN_PP3300_WLAN_L signal. ......................................................................
mb/google/ampton: Fix polarity of EN_PP3300_WLAN_L signal.
WiFi enable signal Was configured and driven as active-high, but the signal is actually active-low.
BUG=b:130196983 BRANCH=none TEST=Verified WiFi still works after boot, and also after a suspend/resume cycle. Device powers down correctly using "poweroff". Tested EVT unit.
Change-Id: I64a67f73564188ad0548a1a770169ef2bca47453 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/octopus/variants/ampton/gpio.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/32255/2
Hello Justin TerAvest, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32255
to look at the new patch set (#3).
Change subject: mb/google/ampton: Fix polarity of EN_PP3300_WLAN_L signal. ......................................................................
mb/google/ampton: Fix polarity of EN_PP3300_WLAN_L signal.
WiFi enable signal Was configured and driven as active-high, but the signal is actually active-low.
BUG=b:130196983 BRANCH=none TEST=Verified WiFi still works after boot, and also after a suspend/resume cycle. Device powers down correctly using "poweroff".
Change-Id: I64a67f73564188ad0548a1a770169ef2bca47453 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/octopus/variants/ampton/gpio.c 1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/32255/3
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32255 )
Change subject: mb/google/ampton: Fix polarity of EN_PP3300_WLAN_L signal. ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/32255/3/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/ampton/gpio.c:
https://review.coreboot.org/#/c/32255/3/src/mainboard/google/octopus/variant... PS3, Line 250: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 1, DEEP, NONE, Tx0RxDCRx0, DISPUPD), line over 80 characters
Hello Justin TerAvest, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32255
to look at the new patch set (#4).
Change subject: mb/google/ampton: Fix polarity of EN_PP3300_WLAN_L signal. ......................................................................
mb/google/ampton: Fix polarity of EN_PP3300_WLAN_L signal.
WiFi enable signal Was configured and driven as active-high, but the signal is actually active-low.
BUG=b:130196983 BRANCH=none TEST=Verified WiFi still works after boot, and also after a suspend/resume cycle. Device powers down correctly using "poweroff".
Change-Id: I64a67f73564188ad0548a1a770169ef2bca47453 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/octopus/variants/ampton/gpio.c 1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/32255/4
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32255 )
Change subject: mb/google/ampton: Fix polarity of EN_PP3300_WLAN_L signal. ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/#/c/32255/4/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/ampton/gpio.c:
https://review.coreboot.org/#/c/32255/4/src/mainboard/google/octopus/variant... PS4, Line 249: EN_PP3300_WLAN EN_PP3300_WLAN_L
https://review.coreboot.org/#/c/32255/4/src/mainboard/google/octopus/variant... PS4, Line 310: EN_PP3300_WLAN same here
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32255 )
Change subject: mb/google/ampton: Fix polarity of EN_PP3300_WLAN_L signal. ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/#/c/32255/4/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/ampton/gpio.c:
https://review.coreboot.org/#/c/32255/4/src/mainboard/google/octopus/variant... PS4, Line 249: EN_PP3300_WLAN
EN_PP3300_WLAN_L
Done
https://review.coreboot.org/#/c/32255/4/src/mainboard/google/octopus/variant... PS4, Line 310: EN_PP3300_WLAN
same here
Done
Hello Justin TerAvest, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32255
to look at the new patch set (#5).
Change subject: mb/google/ampton: Fix polarity of EN_PP3300_WLAN_L signal. ......................................................................
mb/google/ampton: Fix polarity of EN_PP3300_WLAN_L signal.
WiFi enable signal Was configured and driven as active-high, but the signal is actually active-low.
BUG=b:130196983 BRANCH=none TEST=Verified WiFi still works after boot, and also after a suspend/resume cycle. Device powers down correctly using "poweroff".
Change-Id: I64a67f73564188ad0548a1a770169ef2bca47453 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/octopus/variants/ampton/gpio.c 1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/32255/5
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32255 )
Change subject: mb/google/ampton: Fix polarity of EN_PP3300_WLAN_L signal. ......................................................................
Patch Set 5: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32255 )
Change subject: mb/google/ampton: Fix polarity of EN_PP3300_WLAN_L signal. ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/#/c/32255/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32255/5//COMMIT_MSG@7 PS5, Line 7: mb/google/ampton: Fix polarity of EN_PP3300_WLAN_L signal. Please remove the dot/period at the end of the commit message summary.
https://review.coreboot.org/#/c/32255/5//COMMIT_MSG@9 PS5, Line 9: Was was
https://review.coreboot.org/#/c/32255/5//COMMIT_MSG@14 PS5, Line 14: TEST=Verified WiFi still works after boot, and also : after a suspend/resume cycle. Device powers down : correctly using "poweroff". Please use the fully allowed text width.
Hello Justin TerAvest, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32255
to look at the new patch set (#6).
Change subject: mb/google/ampton: Fix polarity of EN_PP3300_WLAN_L signal. ......................................................................
mb/google/ampton: Fix polarity of EN_PP3300_WLAN_L signal.
WiFi enable signal was configured and driven as active-high, but the signal is |To start the server in this Emacs process, stop the existing actually active-low
BUG=b:130196983 BRANCH=none TEST=Verified WiFi still works after boot, and also after a suspend/resume cycle. Device powers down correctly using "poweroff".
Change-Id: I64a67f73564188ad0548a1a770169ef2bca47453 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/octopus/variants/ampton/gpio.c 1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/32255/6
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32255 )
Change subject: mb/google/ampton: Fix polarity of EN_PP3300_WLAN_L signal. ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/#/c/32255/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32255/5//COMMIT_MSG@7 PS5, Line 7: mb/google/ampton: Fix polarity of EN_PP3300_WLAN_L signal.
Please remove the dot/period at the end of the commit message summary.
Done
https://review.coreboot.org/#/c/32255/5//COMMIT_MSG@9 PS5, Line 9: Was
was
Done
https://review.coreboot.org/#/c/32255/5//COMMIT_MSG@14 PS5, Line 14: TEST=Verified WiFi still works after boot, and also : after a suspend/resume cycle. Device powers down : correctly using "poweroff".
Please use the fully allowed text width.
Done
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32255 )
Change subject: mb/google/ampton: Fix polarity of EN_PP3300_WLAN_L signal. ......................................................................
mb/google/ampton: Fix polarity of EN_PP3300_WLAN_L signal.
WiFi enable signal was configured and driven as active-high, but the signal is |To start the server in this Emacs process, stop the existing actually active-low
BUG=b:130196983 BRANCH=none TEST=Verified WiFi still works after boot, and also after a suspend/resume cycle. Device powers down correctly using "poweroff".
Change-Id: I64a67f73564188ad0548a1a770169ef2bca47453 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/32255 Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/octopus/variants/ampton/gpio.c 1 file changed, 5 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/octopus/variants/ampton/gpio.c b/src/mainboard/google/octopus/variants/ampton/gpio.c index 984dae0..6044cd2 100644 --- a/src/mainboard/google/octopus/variants/ampton/gpio.c +++ b/src/mainboard/google/octopus/variants/ampton/gpio.c @@ -246,7 +246,9 @@ /* SCC COMMUNITY GPIOS */ PAD_NC(GPIO_176, UP_20K), /* SMB_ALERTB -- unused */ PAD_NC(GPIO_177, UP_20K), /* SMB_CLK -- unused */ - PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 1, DEEP, NONE, Tx1RxDCRx0, DISPUPD), /* EN_PP3300_WLAN */ + /* EN_PP3300_WLAN_L */ + PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 1, DEEP, NONE, Tx0RxDCRx0, + DISPUPD), PAD_NC(GPIO_179, NONE), /* SDCARD_CLK -- unused */ PAD_NC(GPIO_180, NONE), /* SDCARD_CMD -- unused */ PAD_NC(GPIO_181, UP_20K), /* SDCARD_D0 -- unused */ @@ -305,11 +307,11 @@ PAD_CFG_NF(GPIO_83, NONE, DEEP, NF1), /* H1_SLAVE_SPI_MOSI_R */
/* Enable power to wifi early in bootblock and de-assert PERST#. */ - PAD_CFG_GPO(GPIO_178, 1, DEEP), /* EN_PP3300_WLAN */ + PAD_CFG_GPO(GPIO_178, 0, DEEP), /* EN_PP3300_WLAN_L */ PAD_CFG_GPO(GPIO_164, 0, DEEP), /* WLAN_PE_RST */
/* - * ESPI_IO1 acts as ALERT# (which is open-drain) and requies a weak + * ESPI_IO1 acts as ALERT# (which is open-drain) and requires a weak * pull-up for proper operation. Since there is no external pull present * on this platform, configure an internal weak pull-up. */