Attention is currently required from: Felix Singer, Maximilian Brune.
Maxim has posted comments on this change by Maxim. ( https://review.coreboot.org/c/coreboot/+/83003?usp=email )
Change subject: util/intelp2m: Remove blank line after '{'
......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS3:
These small fixes in the generator do not affect the configuration, but allow us to avoid future fixes ( CB:81484 )
File util/intelp2m/main.go:
https://review.coreboot.org/c/coreboot/+/83003/comment/12380981_f348dbac?usp... :
PS2, Line 24: static const struct pad_config gpio_table[] = {
: `)
You are removing the blank line in the generated code. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83003?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1141ca630cb6d9a46be5bce2b434762ef8e6fdd0
Gerrit-Change-Number: 83003
Gerrit-PatchSet: 3
Gerrit-Owner: Maxim
max.senia.poliak@gmail.com
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Comment-Date: Sun, 16 Jun 2024 09:19:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com