Change in coreboot[master]: mb/google/volteer: config QS silicon devices for CSE LITE

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Mark Hsieh (Code Review)

2 Sep 2020 2 Sep '20

2:57 a.m.

Mark Hsieh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45018 )

Change subject: mb/google/volteer: config QS silicon devices for CSE LITE ......................................................................

mb/google/volteer: config QS silicon devices for CSE LITE

Configure eldrid to use CSE Lite.

BUG=b:158140797 TEST=cd to volteer's asset_generation folder, execute "./gen_all_variant_images.sh" and verify that all variant images are produced.

Signed-off-by: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Change-Id: I357abdac4102f358d3aa1cb50f600312039ef140 --- M src/mainboard/google/volteer/Kconfig.name 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/45018/1

diff --git a/src/mainboard/google/volteer/Kconfig.name b/src/mainboard/google/volteer/Kconfig.name index 1d9a3db..1980dd5 100644 --- a/src/mainboard/google/volteer/Kconfig.name +++ b/src/mainboard/google/volteer/Kconfig.name @@ -8,6 +8,7 @@ config BOARD_GOOGLE_ELDRID bool "-> Eldrid" select BOARD_GOOGLE_BASEBOARD_VOLTEER + select SOC_INTEL_CSE_LITE_SKU

config BOARD_GOOGLE_HALVOR bool "-> Halvor"

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

Caveh Jalali (Code Review)

2 Sep 2 Sep

3:11 a.m.

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45018 )

Change subject: mb/google/volteer: config QS silicon devices for CSE LITE ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45018 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I357abdac4102f358d3aa1cb50f600312039ef140 Gerrit-Change-Number: 45018 Gerrit-PatchSet: 1 Gerrit-Owner: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Raj Astekar raj.astekar@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Jamie Ryu jamie.m.ryu@intel.com Gerrit-CC: Mice Lin mice_lin@wistron.corp-partner.google.com Gerrit-CC: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Gerrit-CC: Sathyanarayana Nujella sathyanarayana.nujella@intel.com Gerrit-CC: Scott Chao scott_chao@wistron.corp-partner.google.com Gerrit-Comment-Date: Wed, 02 Sep 2020 06:11:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

1:07 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45018 )

Change subject: mb/google/volteer: config QS silicon devices for CSE LITE ......................................................................

Patch Set 1:

Since Eldrid was the last holdout to switch to the CSE Lite SKU, should we just move the SOC_INTEL_CSE_LITE_SKU selection into the Kconfig file so it applies to all Volteer boards?

-- To view, visit https://review.coreboot.org/c/coreboot/+/45018 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I357abdac4102f358d3aa1cb50f600312039ef140 Gerrit-Change-Number: 45018 Gerrit-PatchSet: 1 Gerrit-Owner: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Raj Astekar raj.astekar@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Jamie Ryu jamie.m.ryu@intel.com Gerrit-CC: Mice Lin mice_lin@wistron.corp-partner.google.com Gerrit-CC: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Gerrit-CC: Sathyanarayana Nujella sathyanarayana.nujella@intel.com Gerrit-CC: Scott Chao scott_chao@wistron.corp-partner.google.com Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Wed, 02 Sep 2020 16:07:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Caveh Jalali (Code Review)

7:13 p.m.

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45018 )

Change subject: mb/google/volteer: config QS silicon devices for CSE LITE ......................................................................

Patch Set 1:

...

Patch Set 1:

Since Eldrid was the last holdout to switch to the CSE Lite SKU, should we just move the SOC_INTEL_CSE_LITE_SKU selection into the Kconfig file so it applies to all Volteer boards?

ya... i pondered that, too. should be a straight forward consolidation we can do out-of-band when we get a chance.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45018 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I357abdac4102f358d3aa1cb50f600312039ef140 Gerrit-Change-Number: 45018 Gerrit-PatchSet: 1 Gerrit-Owner: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Raj Astekar raj.astekar@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Jamie Ryu jamie.m.ryu@intel.com Gerrit-CC: Mice Lin mice_lin@wistron.corp-partner.google.com Gerrit-CC: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Gerrit-CC: Sathyanarayana Nujella sathyanarayana.nujella@intel.com Gerrit-CC: Scott Chao scott_chao@wistron.corp-partner.google.com Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Wed, 02 Sep 2020 22:13:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Georgi (Code Review)

8 Sep 8 Sep

2:26 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45018 )

Change subject: mb/google/volteer: config QS silicon devices for CSE LITE ......................................................................

mb/google/volteer: config QS silicon devices for CSE LITE

Configure eldrid to use CSE Lite.

BUG=b:158140797 TEST=cd to volteer's asset_generation folder, execute "./gen_all_variant_images.sh" and verify that all variant images are produced.

Signed-off-by: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Change-Id: I357abdac4102f358d3aa1cb50f600312039ef140 Reviewed-on: https://review.coreboot.org/c/coreboot/+/45018 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Caveh Jalali caveh@chromium.org --- M src/mainboard/google/volteer/Kconfig.name 1 file changed, 1 insertion(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Caveh Jalali: Looks good to me, approved

config BOARD_GOOGLE_HALVOR bool "-> Halvor"

-- To view, visit https://review.coreboot.org/c/coreboot/+/45018 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I357abdac4102f358d3aa1cb50f600312039ef140 Gerrit-Change-Number: 45018 Gerrit-PatchSet: 2 Gerrit-Owner: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Raj Astekar raj.astekar@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Jamie Ryu jamie.m.ryu@intel.com Gerrit-CC: Mice Lin mice_lin@wistron.corp-partner.google.com Gerrit-CC: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Sathyanarayana Nujella sathyanarayana.nujella@intel.com Gerrit-CC: Scott Chao scott_chao@wistron.corp-partner.google.com Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: merged

9elements QA (Code Review)

4:01 a.m.

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45018 )

Change subject: mb/google/volteer: config QS silicon devices for CSE LITE ......................................................................

Patch Set 2:

Automatic boot test returned (PASS/FAIL/TOTAL): 7/1/8 "QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/18069 "QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/18068 "QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/18067 "QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/18066 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/18065 "HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/18072 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/18071 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/18070

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/45018 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I357abdac4102f358d3aa1cb50f600312039ef140 Gerrit-Change-Number: 45018 Gerrit-PatchSet: 2 Gerrit-Owner: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Raj Astekar raj.astekar@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Jamie Ryu jamie.m.ryu@intel.com Gerrit-CC: Mice Lin mice_lin@wistron.corp-partner.google.com Gerrit-CC: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Sathyanarayana Nujella sathyanarayana.nujella@intel.com Gerrit-CC: Scott Chao scott_chao@wistron.corp-partner.google.com Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Tue, 08 Sep 2020 07:01:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1685

days inactive

1691

days old

coreboot-gerrit@coreboot.org

5 comments

5 participants

tags (0)

participants (5)

9elements QA (Code Review)
Caveh Jalali (Code Review)
Mark Hsieh (Code Review)
Patrick Georgi (Code Review)
Tim Wawrzynczak (Code Review)