Attention is currently required from: Jonathan Zhang, Johnny Lin, Shuming Chu (Shuming), Arthur Heymans, Kyösti Mälkki, TangYiwei.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69222 )
Change subject: cpu/x86/topology: Add code to fill in topology on struct path
......................................................................
Patch Set 15:
(5 comments)
File src/cpu/x86/topology.c:
https://review.coreboot.org/c/coreboot/+/69222/comment/eed9e146_442542a3
PS15, Line 3: include <assert.h>
If I'm not wrong, <assert.h> is not used.
https://review.coreboot.org/c/coreboot/+/69222/comment/fda36e2d_598a1cf0
PS15, Line 4: <arch/cpu.h>
I'd include <cpu/cpu.h> instead
https://review.coreboot.org/c/coreboot/+/69222/comment/30178c8b_486d150d
PS15, Line 26: enum cb_err
maybe include <types.h>
https://review.coreboot.org/c/coreboot/+/69222/comment/83762803_a40a9bef
PS15, Line 34: Cpu
CPU ?
File src/include/cpu/x86/topology.h:
https://review.coreboot.org/c/coreboot/+/69222/comment/f6270fad_8af866fc
PS15, Line 10: device
include <device/device.h> ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69222
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2210eb9b663dd90941a64132aa7154440dc7e5a9
Gerrit-Change-Number: 69222
Gerrit-PatchSet: 15
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Reviewer: TangYiwei
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: TangYiwei
Gerrit-Comment-Date: Sun, 01 Jan 2023 23:28:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment