Attention is currently required from: Nico Huber, Julius Werner, Arthur Heymans, Kyösti Mälkki.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55436 )
Change subject: device: Add fixed_mem_resource64()
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I mean, if you just want to be able to submit your next patch, you can simply have coccinelle rewrit […]
One reason to have the API take values in KiB could be to avoid having to deal with 64-bit values, which could unnecessarily bloat the code. I've made several mistakes when dealing with KiB values, so I think using values in bytes is a good idea. Still, I believe that changing this API in a single commit is just unreviewable, and I'd much prefer to have these two APIs coexist for a while.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55436
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2cc9ef94b60d62aaf4374f400b7e05b86e4664d2
Gerrit-Change-Number: 55436
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Fri, 11 Jun 2021 21:47:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment