Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Paul Menzel, Karthik Ramasubramanian.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56684 )
Change subject: soc/amd/cezanne/early_fch: Perform early SPI initialization
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56684/comment/49684d61_64bfb448
PS1, Line 13: TEST=Build and boot to OS in Guybrush.
Does this add time to the boot?
Not appreciably, no. Any code that's added obviously adds a little. This add significantly less time than a single printf.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56684
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibfbe6e16bd6b0dd46c13cecf2a35f0c0b4576b88
Gerrit-Change-Number: 56684
Gerrit-PatchSet: 4
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 30 Aug 2021 18:48:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment